-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: long tracker #529
Feat: long tracker #529
Conversation
base floes from (i-1)th iteration
to retrieve last row of each group in pairs
within group (trajectory) for correct bookkeeping of area_mismatch and corr columns
calculate time difference between floes
add missing columns for joining
function to reset distinct values in a DataFrame column
function to merge floe properties and similarity ratios
unify uuid
to use :uuid column
rightdf missing cols
To retrieve right-hand matches from prelim pairs during the ith iteration
macro for enhanced test set output formatting
to use ntestset and remove redundant code
from tracker.jl
to use long tracker
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
on importance of the order of adding required fields
to test independence of ordering
add latitude/longitude data to trajectories and update column names
in long_tracker
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good! I've a few clarifying questions. At this point, I'd really like to see some extra test images and trajectories with demonstrations that the tracking works over multiple days with gaps in-between.
remove note about dependency of column order
function to insert gaps in props array
outside test set
for better output feedback during testing
for reusability
This pull request includes several changes to the
IceFloeTracker
project, focusing on improving the tracking of ice floes over multiple days, adding new functionality, and updating the corresponding tests. The most important changes include the addition of thelong_tracker
function, updates to the notebook, and the introduction of new helper functions.New functionality:
long_tracker
function to track ice floes over multiple days, including the necessary helper functions such asfind_floe_matches
,get_unmatched
,get_trajectory_heads
, and others. (src/tracker/long_tracker.jl
,src/tracker/tracker-funcs.jl
)long_tracker
file in the main module. (src/IceFloeTracker.jl
)Notebook updates:
track-floes.ipynb
notebook to use the newlong_tracker
function and added new data processing steps and visualizations. (notebooks/track-floes/track-floes.ipynb
)Testing improvements:
long_tracker
function, including cases with gaps in data. (test/test-long-tracker.jl
)@ntestset
macro for better test organization. (test/runtests.jl
,test/test-matchcorr.jl
)Notes about
long_tracker
_pairfloes
withinpairfloes
which is used the pipeline workflow.IceFloeTracker.jl/src/tracker/tracker.jl
Lines 226 to 246 in e7be057
_pairfloes
as currently defined does too much work. Besides the matching, it also adds unique ids to floes, pass times, floe masks, and psi-s curves.long_tracker
expects all those data to be included in the inputprops
object. See sample workflows in the test suite and the illustrative notebook.TODO