Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make sort! declaration extend Base.sort! #509

Merged
merged 1 commit into from
Nov 13, 2024
Merged

fix: make sort! declaration extend Base.sort! #509

merged 1 commit into from
Nov 13, 2024

Conversation

hollandjg
Copy link
Collaborator

... rather than shadowing it, which breaks the find_reflectance_peaks function in find_ice_labels.jl under some circumstances

@hollandjg
fix: make sort! declaration extend Base.sort!
17679d5 
... rather than shadowing it, which breaks the find_reflectance_peaks function in find_ice_labels.jl under some circumstances
@hollandjg hollandjg marked this pull request as ready for review November 12, 2024 15:13
@cpaniaguam cpaniaguam self-requested a review November 12, 2024 16:31
cpaniaguam
cpaniaguam approved these changes Nov 12, 2024
View reviewed changes
Copy link
Member

@cpaniaguam cpaniaguam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I had a PR for this elsewhere but let's just get it fixed in this one.

@hollandjg hollandjg merged commit 8d0b778 into main Nov 13, 2024
7 checks passed
@hollandjg hollandjg deleted the fix-sort-shadowing branch November 13, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpaniaguam cpaniaguam cpaniaguam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hollandjg @cpaniaguam