Impose minima and related functions #489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
2 tasks
cpaniaguam
force-pushed
the
488-impose-minima
branch
from
048a0cd to
c50679b
Compare
danielmwatkins
previously approved these changes
Nov 8, 2024
cpaniaguam
dismissed
danielmwatkins’s stale review
The merge-base changed after approval.
tdivoll
approved these changes
Nov 11, 2024
|
|
||
| It supports both integer and grayscale images using different implementations for each. | ||
| """ | ||
| function impose_minima(I::AbstractArray{T}, BW::AbstractArray{Bool}) where {T<:Integer} |
There was a problem hiding this comment.
minor detail, but consider adding a comment after where {T<:Integer} #color image.
Then below on line 139, consider where {T<:AbstractFloat} #gray image.
It's clear in the docstring, so maybe not needed.
| function impose_minima(I::AbstractArray{T}, BW::AbstractArray{Bool}) where {T<:Integer} | ||
| marker = 255 .* BW | ||
| mask = imcomplement(min.(I .+ 1, 255 .- marker)) | ||
| reconstructed = sk_morphology.reconstruction(marker, mask) |
There was a problem hiding this comment.
Is this reconstruction from skimage closer to the matlab implementation compared to the reconstruction we were using before?
There was a problem hiding this comment.
It's the same but a bit faster.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.