479 imbrighten #480
Merged
479 imbrighten #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
3 tasks
danielmwatkins
previously approved these changes
Nov 8, 2024
tdivoll
requested changes
Nov 11, 2024
| @@ -71,7 +71,7 @@ include("branch.jl") | |||
| include("special_strels.jl") | |||
| include("tilingutils.jl") | |||
| include("histogram_equalization.jl") | |||
| include("imadjust.jl") | |||
There was a problem hiding this comment.
I think the CI fails because of this deletion. Maybe keep the include("imadjust.jl") and add include("brighten.jl")? It looks like there is still an imadjust.jl script, suggesting that maybe we need both?
There was a problem hiding this comment.
Must have done that trying to resolve merge conflicts. I think it's fixed now. Thanks.
|
I haven't seen this before. It looks like there is still a test file for |
|
It's missing the call to the @test macro. I'll fix that! |
tdivoll
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #479.