Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support labeled segmented images #458

Merged
merged 39 commits into from
Nov 6, 2024
Merged

Support labeled segmented images #458

merged 39 commits into from
Nov 6, 2024

Conversation

hollandjg
Copy link
Collaborator

@hollandjg hollandjg commented Oct 23, 2024 •
edited
Loading

Add support for integer floe masks, in addition to boolean ones.

The primary place this interfaces with the existing code is when adding the cropped floe images to the dataframe during the tracking script. The integer-labeled floes from the images are cast to BitMatrix and the rest of the code should work as before.

hollandjg added 30 commits July 24, 2024 13:38
@hollandjg
use julia via feature rather than devcontainer
d456e19
@hollandjg
remove nonexistent post-create script
19071aa
@hollandjg
make building the conda environment work by unpinning python deps
a2ae16d
@hollandjg
add notes on test_results
2c539d7
@hollandjg
remove extra newlines
4f90d1e
@hollandjg
Add xsucces note
bdadf25
@hollandjg
Merge remote-tracking branch 'upstream/main' into devcontainer-unpin-…
fadb3e5 
…python-deps
@hollandjg
add additional cropfloes functions to handle labeled images
4b258b2
@hollandjg
update types for pairfloes to pass tests
f277cd4
@hollandjg
fix sort function - wasn't working before
647c787
@hollandjg
fix image types for cropfloes
201b390
@hollandjg
add support for float centroids in convertcentroid
9ee4833
@hollandjg
add support for unsigned integer image types in boundary trace
52efada
@hollandjg
remove unnecessary casting
84dba7d
@hollandjg
update image type
5dc27cf
@hollandjg
chore: remove unexpected change
a912c08
@hollandjg
fix extra spaces
8500c12
@hollandjg
remove unneeded change to readme
03570f7
@hollandjg
remove unnecessary file
fd7a4e7
@hollandjg
rename FloeLabelsIntOrBool from floesimgvectortype
fa933bc
@hollandjg
add missing filename
cc98ca8
@hollandjg
simplify type description for FloeLabelsIntOrBool
ef4134b
@hollandjg
make types more specific
3c85362
@hollandjg
rename FloeLabelsImage from FloeLabelsIntOrBool
14135bc
@hollandjg
Merge branch 'main' into support-labeled-segmented-images
789bf1e
@hollandjg
reorder functions to minimize the size of the diff
cf3c52e
@hollandjg
simplify type for segmented_imgs
f563e44
@hollandjg
remove info print
1aec770
@hollandjg
fix weird change in find_reflectance_peaks
e816831 
(unrelated to the labeled segmented images.)
@hollandjg
remove extra debugging call
48ac134
@hollandjg hollandjg marked this pull request as ready for review October 23, 2024 20:51
cpaniaguam
cpaniaguam reviewed Oct 23, 2024
View reviewed changes
src/regionprops.jl Outdated Show resolved Hide resolved
cpaniaguam
cpaniaguam reviewed Oct 23, 2024
View reviewed changes
src/regionprops.jl Outdated Show resolved Hide resolved
cpaniaguam
cpaniaguam reviewed Oct 24, 2024
View reviewed changes
src/regionprops.jl Outdated Show resolved Hide resolved
This was referenced Oct 24, 2024
Open
Open
@hollandjg hollandjg requested a review from cpaniaguam October 28, 2024 16:51
cpaniaguam
cpaniaguam approved these changes Nov 6, 2024
View reviewed changes
Copy link
Member

@cpaniaguam cpaniaguam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hollandjg hollandjg merged commit 644d1f0 into main Nov 6, 2024
7 checks passed
@hollandjg hollandjg deleted the support-labeled-segmented-images branch November 6, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirestrepo mirestrepo mirestrepo left review comments

@cpaniaguam cpaniaguam cpaniaguam approved these changes

@danielmwatkins danielmwatkins Awaiting requested review from danielmwatkins

@tdivoll tdivoll Awaiting requested review from tdivoll

@mkkim400 mkkim400 Awaiting requested review from mkkim400

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hollandjg @mirestrepo @cpaniaguam