-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tiled workflow feats #451
Closed
Closed
Tiled workflow feats #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d add mat2uint8 helper
…eflectance_peaks calls
for tiled workflow
…mprove reshaping logic
…and column blocks
cpaniaguam
force-pushed
the
tiled-workflow-feats
branch
from
October 22, 2024 18:22
70ea000
to
d00a448
Compare
cpaniaguam
force-pushed
the
tiled-workflow-feats
branch
from
November 5, 2024 01:14
9d36a8c
to
8755d9c
Compare
…nstruction in reconstruct function
…landmask function
…d optimize with threading
…er for reconstruction
…and improve to_uint8 function
…r improved reconstruction
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds several features needed for the tiled workflow in
master.m
from line 593 to line 657.A similar workflow exists from line 882 to line 944.
I'd appreciate reviewers pay close attention to the implementation of the
get_nlabels
function. The logic in the original workflows is quite convoluted and this implementation seeks to simplify it. Thanks in advance!Finally, I didn't like how
ImageConstrastAdjustment.build_histogram
or the corresponding function fromStatsBase
do their thing for this use case, so a friendlier implementation is also included.