Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update trigger-docker-julia.yml to trigger Docker build on release #372

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

cpaniaguam
Copy link
Member

No description provided.

@cpaniaguam cpaniaguam requested a review from tdivoll April 5, 2024 15:55
Copy link

codecov bot commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.67%. Comparing base (fc4e07b) to head (640242b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #372   +/-   ##
=======================================
  Coverage   90.67%   90.67%           
=======================================
  Files          29       29           
  Lines         954      954           
=======================================
  Hits          865      865           
  Misses         89       89           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@tdivoll tdivoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This makes sense. I guess the action just checks for changes in the version number?

@tdivoll
Copy link
Collaborator

tdivoll commented Apr 5, 2024

We'll have to make a new minor release to test it.

@cpaniaguam
Copy link
Member Author

We'll have to make a new minor release to test it.

I guess so. It could be a patch also. I can add the label [published] to the current release to see if that'll trigger the other action as well.

@cpaniaguam cpaniaguam merged commit 57b557d into main Apr 5, 2024
4 checks passed
@cpaniaguam cpaniaguam deleted the feat-trigger-on-release branch April 5, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants