feat: floe labeling #347
Merged
feat: floe labeling #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update notebook
Closed
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #347 +/- ##
==========================================
- Coverage 91.84% 90.46% -1.39%
==========================================
Files 29 29
Lines 871 902 +31
==========================================
+ Hits 800 816 +16
- Misses 71 86 +15
☔ View full report in Codecov by Sentry. |
tdivoll
reviewed
Oct 11, 2023
src/tracker/tracker.jl
Outdated
| Tag floes in the `data.props` by assigning a unique `Floe_ID`` to each floe in each image using pair data in `pairs`. The ID is stored in the `Floe_ID` column of the `props` DataFrame in `data`. | ||
|
|
||
| # Arguments | ||
| - `data::Data`: the data structure containing the images and properties of the floes (output of `IFTPipeline.extractfeatures`). The `props` field of `data` is modified in-place. |
There was a problem hiding this comment.
Suggested change
| - `data::Data`: the data structure containing the images and properties of the floes (output of `IFTPipeline.extractfeatures`). The `props` field of `data` is modified in-place. | |
| - `floedata::Data`: the data structure containing the images and properties of the floes (output of `IFTPipeline.extractfeatures`). The `props` field of `data` is modified in-place. |
tdivoll
reviewed
Oct 11, 2023
src/tracker/tracker.jl
Outdated
| """ | ||
| tagfloes!(floedata, pairs) | ||
|
|
||
| Tag floes in the `data.props` by assigning a unique `Floe_ID`` to each floe in each image using pair data in `pairs`. The ID is stored in the `Floe_ID` column of the `props` DataFrame in `data`. |
There was a problem hiding this comment.
Suggested change
| Tag floes in the `data.props` by assigning a unique `Floe_ID`` to each floe in each image using pair data in `pairs`. The ID is stored in the `Floe_ID` column of the `props` DataFrame in `data`. | |
| Tag floes in the `data.props` by assigning a unique `Floe_ID` to each floe in each image using pair data in `pairs`. The ID is stored in the `Floe_ID` column of the `props` DataFrame in `data`. |
tdivoll
previously approved these changes
Oct 11, 2023
src/tracker/tracker.jl
Outdated
| - `data::Data`: the data structure containing the images and properties of the floes (output of `IFTPipeline.extractfeatures`). The `props` field of `data` is modified in-place. | ||
| - `pairs`: the output of `pairfloes`. | ||
| """ | ||
| function tagfloes!(props, pairs) |
There was a problem hiding this comment.
Here the first arg is props, but in the docstring it is floedata. Maybe update the docstring so it is consistent?
|
Using a different implementation using early tagging and mappings for relabeling. |
tdivoll
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@danielmwatkins @ellenbuckley See
notebooks/track-floes/track-floes.ipynbfor a complete sample workflow with test data.TODO: Update
trackinhttps://github.com/WilhelmusLab/ice-floe-tracker-pipeline/blob/main/src/tracker.jlso it does floe labeling.#339