Fix text diff of large chunks to not emit last blank line #731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can confirm that this fixes the aforementioned crash on 0.59.0. |
myers_diff doesn't emit the last blank line, so I made the fall-back path do the same. This was originally intended to fix Wilfred#702, but fixes crash with sample_files/big_text_hunk_?.txt on 0.59.0. It probably fixes Wilfred#739.
|
Superseded by 1ac9553 and other fixes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes crash in inline printer, which assumes that hunk lines are within range. I'm not pretty sure if this assumption holds anytime, but myers_diff appears not emitting the last blank line, so I made the fall-back path do the same.This will hopefully fix #702.myers_diff doesn't emit the last blank line, so I made the fall-back path do the same.
This was originally intended to fix #702, but fixes crash with
sample_files/big_text_hunk_?.txton 0.59.0. It probably fixes #739.