Merge pull request #78 from WildernessLabs/develop

Update main for 0.94.2
WildernessLabs · Feb 7, 2023 · c1f3ce8 · c1f3ce8
2 parents dd68a1c + 7e7180d
commit c1f3ce8
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 14 deletions.
diff --git a/Source/Meadow.Contracts/Hardware/Contracts/IOControllers/II2cController.cs b/Source/Meadow.Contracts/Hardware/Contracts/IOControllers/II2cController.cs
@@ -10,29 +10,22 @@ public interface II2cController
         /// </summary>
         public static I2cBusSpeed DefaultI2cBusSpeed = I2cBusSpeed.Standard;
 
-        /// <summary>
-        /// Creates an I2C bus instance for the default pins.
-        /// </summary>
-        /// <param name="busNumber">The bus number</param>
-        /// <returns>An instance of an I2cBus</returns>
-        II2cBus CreateI2cBus(
-            int busNumber = 0);
-
         /// <summary>
         /// Creates an I2C bus instance for the default pins and the requested bus speed
         /// </summary>
-        /// <param name="busSpeed">The bus speed.</param>
+        /// <param name="busSpeed">The bus speed</param>
         /// <param name="busNumber">The bus number</param>
         /// <returns>An instance of an I2cBus</returns>
         II2cBus CreateI2cBus(
-            int busNumber,
-            I2cBusSpeed busSpeed
+            int busNumber = 1,
+            I2cBusSpeed busSpeed = I2cBusSpeed.Standard
         );
 
         /// <summary>
         /// Creates an I2C bus instance for the requested pins and bus speed
         /// </summary>
-        /// <param name="busSpeed">The bus speed.</param>
+        /// <param name="pins">An array of two pins holding the I2C clock and data pins</param>
+        /// <param name="busSpeed">The bus speed</param>
         /// <returns>An instance of an I2cBus</returns>
         II2cBus CreateI2cBus(
             IPin[] pins,
@@ -42,7 +35,9 @@ I2cBusSpeed busSpeed
         /// <summary>
         /// Creates an I2C bus instance for the requested pins and bus speed
         /// </summary>
-        /// <param name="busSpeed">The bus speed.</param>
+        /// <param name="clock">The I2C clock pin</param>
+        /// <param name="data">The I2C data pin</param>
+        /// <param name="busSpeed">The bus speed</param>
         /// <returns>An instance of an I2cBus</returns>
         II2cBus CreateI2cBus(
             IPin clock,

diff --git a/Source/Meadow.Contracts/IPlatformOS.cs b/Source/Meadow.Contracts/IPlatformOS.cs
@@ -41,7 +41,7 @@ public partial interface IPlatformOS : IPowerController
         public SerialPortName? GetSerialPortName(string portName)
         {
             return GetSerialPortNames().FirstOrDefault(
-                p => string.Compare(p.FriendlyName, "portName", true) == 0
+                p => string.Compare(p.FriendlyName, portName, true) == 0
                  || string.Compare(p.SystemName, portName, true) == 0);
         }
     }