Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 4.1x token factory #292

Merged
merged 3 commits into from
Dec 28, 2023
Merged

feat: 4.1x token factory #292

merged 3 commits into from
Dec 28, 2023

Conversation

devbull25
Copy link
Contributor

@devbull25 devbull25 commented Dec 28, 2023 •
edited
Loading

Description and Motivation

This PR applies Terra Token Factory module and bindings to the chain, with the aim of:

  • maintaining compatibility with current notional's token factory fork
  • bring new features of token factory
  • reduce maintain overhead

Changes

  • terra-alliance 2.2 → terra-alliance 3.2.0
  • notional wasm factory → terra/core/x/tokenfactory
  • terra-money/alliance/custom/bank → terra-money/core/v2/custom/bank

Related Issues

Token Factory Issue

Checklist:

  • I have read Migaloo's contribution guidelines.
  • My pull request has a sound title and description (not something vague like Update index.md)
  • All existing and new tests are passing.
  • I updated/added relevant documentation.
  • The code is formatted properly golangci-lint run ./... --fix.

hoank101
hoank101 approved these changes Dec 28, 2023
View reviewed changes
Copy link
Contributor

@hoank101 hoank101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hoank101 hoank101 merged commit 54042e3 into develop Dec 28, 2023
11 of 14 checks passed
@hoank101 hoank101 mentioned this pull request Jan 2, 2024
Closed
16 tasks
@Sen-Com Sen-Com deleted the 4.1x/token-factory branch June 3, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoank101 hoank101 hoank101 approved these changes

@PolkachuIntern PolkachuIntern Awaiting requested review from PolkachuIntern

@faddat faddat Awaiting requested review from faddat

@Sen-Com Sen-Com Awaiting requested review from Sen-Com

@kerber0x kerber0x Awaiting requested review from kerber0x

@0xFable 0xFable Awaiting requested review from 0xFable

@hieuvubk hieuvubk Awaiting requested review from hieuvubk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devbull25 @hoank101