Skip to content
This repository has been archived by the owner on Jul 6, 2022. It is now read-only.

add sentry configuration #133

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

add sentry configuration #133

wants to merge 5 commits into from

Conversation

kamsz
Copy link

@kamsz kamsz commented Apr 14, 2022

No description provided.

@kamsz kamsz requested a review from 0xFable April 14, 2022 19:53
@kamsz kamsz requested a review from vinodhum as a code owner April 14, 2022 19:53
Copy link
Contributor

@0xFable 0xFable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Some questions but overall looks fine and a very complete PR. Good work


// Flushing before returning is necessary if deploying to Vercel, see
// https://vercel.com/docs/platform/limits#streaming-responses
await Sentry.flush(2000);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are not deploying to vercel, should we drop ?


// Workaround for https://github.com/vercel/next.js/issues/8592, mark when
// getInitialProps has run
errorInitialProps.hasGetInitialPropsRun = true;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again a vercel thing.
ofc all this can stay just unsure if it applies to our current infra now with aws. Best to leave for now prob

Comment on lines +19 to +20
silent: true, // Suppresses all logs
dryRun: true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YOu sure you want both silent and dryRun here ? This is a Sentry concept you know better than I

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants