-
Notifications
You must be signed in to change notification settings - Fork 0
add sentry configuration #133
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ! Some questions but overall looks fine and a very complete PR. Good work
|
||
// Flushing before returning is necessary if deploying to Vercel, see | ||
// https://vercel.com/docs/platform/limits#streaming-responses | ||
await Sentry.flush(2000); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are not deploying to vercel, should we drop ?
|
||
// Workaround for https://github.com/vercel/next.js/issues/8592, mark when | ||
// getInitialProps has run | ||
errorInitialProps.hasGetInitialPropsRun = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again a vercel thing.
ofc all this can stay just unsure if it applies to our current infra now with aws. Best to leave for now prob
silent: true, // Suppresses all logs | ||
dryRun: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
YOu sure you want both silent and dryRun here ? This is a Sentry concept you know better than I
No description provided.