forked from AlexGyver/GyverLamp
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added weather mode #21
Open
cosmos1978
wants to merge
14
commits into
Whilser:master
Choose a base branch
from
cosmos1978:test
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
live weather effect based on openweathermap api
bug fix in mqtt effects list
reduced the number of forecast options
added whlsers config for mqtt via webserver
You can use '/data/2.5/weather?' API call, it gives only current weather, but it is less than 500 bytes bytes long for one city. |
Using arduinojson to parse fields from json api response. show a weather report on the weather page. Show scrolling temp on lamp while in weather mode
added weather report on webpage. |
changed font colors in weather mode effects
shortened descriptions in tab pages
code cleanup
placed a comment wrong. Fixed now
lowered memory footprint significantly by using arduinojson streaming and filtering. Full 4 days forecast in a much smaller footprint.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
you need to configure your openweathermap api key, city name and country code in the main ino file.
Perhaps the saving can be done better and more inline but the other mqtt component.
Also the json output is very large and because I use HTTPclient.getString it will kill the memory if I make a larger request.
so what can be improved is the json parser. Perhaps it was better to use jsonserializer. second I need to find a way to parse and store large json objects