-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added tool for create JSON for content.json file #431
base: main
Are you sure you want to change the base?
Conversation
I have created this tool to generate JSON for content.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated your changes to fit better to the rest of the documentation :)
The tool is awesome, thanks for taking the time to build it 👍
It will definitely help other developers to safe time ^^
PS: This resolves #406 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @MarvinJWendt for improvement 👍
@simonzhexu @amrit-1901 Need to update anything? |
@pratikbutani Give it time :) |
@MarvinJWendt Here I published article : JSON Creator for WhatsApp Sticker Pack |
Hi @pratikbutani and @MarvinJWendt, thank you. Sorry for the delay. Now I am back. One thing I want to suggest and you can help, is to add some validation logic.
You can also add in your form to let them input the "android_play_store_link" and "ios_app_store_link": "", I will need to discuss this with some other team members before I can merge this. Give me a few days. Again, this is great work! Thank you! |
For sure, @simonzhexu I will update as you said. Thank you so much @Zandor300 for approve pull request. <3 Many thanks to @MarvinJWendt for your motivation. 👍 Hopefully it will be merged soon. Thanks again. |
Hi, @pratikbutani , unfortunately, I cannot approve this merge request, as we are not allowed to link to a third party website that may change at any time for the security of developers. I know this may come as a disappointment and I am very sorry. You are welcome to promote your json generator on your own website and through other channels. One thing that would work is creating some sort of script that can be run on the repo that can look at the assets folder and create a json file, something like a python script or shell script. The script would be on the repo and we can review it. |
Hey @simonzhexu, as you mentioned that it would be possible to add a script to the repo: The tool created by @pratikbutani is actually a single But I think this could be a solution, as the file would directly be owned by WhatsApp. I would say that Obviously that would require some changes to the Just a thought.. :) |
Basically I am android developer having good experience to make apps but never tried to make anything in web. This is my first try just because I got the issue to make JSON with all packs. Its tough and time wasting process to make json. I have just put efforts to make very light and simple tool so developer can use it. It would be great inspiration for me that I make it successfully. Thanks for everything. |
Thank you for your support. If I need to do any changes then I will. |
|
Yeah sure, Do let me know what are changes that I have to do? @simonzhexu |
Sounds great, I will circle back to you on more details. Really appreciate what you did. |
Any changes? |
I am working with partnerships team to figure out how to work with you. @pratikbutani , please stay tuned. |
Hello @simonzhexu Is there any changes that I can do? Any update from your side? |
Greetings! What should I do change in JSON Generator to make GIF supported JSON? |
@simonzhexu @MarvinJWendt Do let me know what to do? |
Do let me know what we can do together? |
@simonzhexu @MarvinJWendt I am eagerly waiting for your response. Do let me know what I need to changes? |
Hi @pratikbutani it would be nice to be able to let people run the script inside the repo without going to a website, what I am thinking is, perhaps, we create html page inside this repo and have all the logic inside this repo. User click on the html page inside the repo, and perform the JSON generation, then the html page puts the JSON into the contents.json file. |
This is a great project and really love your work. Sorry for the late response. |
Yeah that will be also good. Do let me know what to do further? |
@pratikbutani , I think the ask from our side is to perform the JSON generation entirely inside this repo without having any code going out to external websites. Do you think it is doable? |
Yes we can do that also. We can put this HTML file inside the repo and open as web link. |
Sounds good. @pratikbutani . Could you update this PR and include all HTML files in the repo? Thank you so much! |
@simonzhexu @BlackGengar Uploaded Zip File. Please take a look. WAStickerApp-JSON-Generator-master.zip Do let me know if any changes required. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Do let me know if I need to change anything here. I will be happy to help. |
I have created tool which is helpful to generate JSON by uploading images and other details. Now it will be easy to create JSON for developers. Enjoy!