-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support phpstan’s dev-master version #16
base: master
Are you sure you want to change the base?
Conversation
@Gallaecio Are these known to be compatible? Seems like we'll get ourselves into a pickle in the future, |
You can never assure that a dev-master will work. I believe that is the point. The thing is, if someone is using the dev-master version of phpstan, hence risking phpstan not working fine itself, shouldn't we allow them to install the dev-master version of phpstan-laravel and, if there is any issue, report it here so that it can be fixed early? |
We need to test on Travis
|
PHPStan 0.10 was released https://github.com/phpstan/phpstan/releases/tag/0.10 😄 |
We need additional changes:
https://github.com/Weebly/phpstan-laravel/blob/master/src/BuilderMethodExtension.php#L52 |
@Gallaecio Can you please take a took into @szepeviktor's comment? So we can merge it, I can't wait to work with Laravel and PHPStan 0.10 😄 |
I consider what @szepeviktor reports beyond the scope of this change. The goal of this change is to allow the installation, even if it does not actually work. |
Fixed in #19 |
Fixes #15