Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support phpstan’s dev-master version #16

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Gallaecio
Copy link

Fixes #15

@twistor
Copy link
Contributor

twistor commented Jun 5, 2018

@Gallaecio Are these known to be compatible? Seems like we'll get ourselves into a pickle in the future,

@Gallaecio
Copy link
Author

You can never assure that a dev-master will work. I believe that is the point. The thing is, if someone is using the dev-master version of phpstan, hence risking phpstan not working fine itself, shouldn't we allow them to install the dev-master version of phpstan-laravel and, if there is any issue, report it here so that it can be fixed early?

@szepeviktor
Copy link

szepeviktor commented Jun 5, 2018

We need to test on Travis

  • with phpstan dev-master (allow-fail)
  • and with phpstan latest

@carusogabriel
Copy link
Contributor

PHPStan 0.10 was released https://github.com/phpstan/phpstan/releases/tag/0.10 😄

@szepeviktor
Copy link

szepeviktor commented Jun 25, 2018

We need additional changes:

PHP Fatal error:  Declaration of Weebly\PHPStan\Laravel\BuilderMethodExtension::setBroker(PHPStan\Broker\Broker $broker) 
must be compatible with PHPStan\Reflection\BrokerAwareExtension::setBroker(PHPStan\Broker\Broker $broker): 
void in .../vendor/weebly/phpstan-laravel/src/BuilderMethodExtension.php on line 15

https://github.com/Weebly/phpstan-laravel/blob/master/src/BuilderMethodExtension.php#L52
https://github.com/phpstan/phpstan/blob/master/src/Reflection/BrokerAwareExtension.php#L10

@carusogabriel
Copy link
Contributor

@Gallaecio Can you please take a took into @szepeviktor's comment? So we can merge it, I can't wait to work with Laravel and PHPStan 0.10 😄

@Gallaecio
Copy link
Author

I consider what @szepeviktor reports beyond the scope of this change. The goal of this change is to allow the installation, even if it does not actually work.

@szepeviktor
Copy link

Fixed in #19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants