Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: agent config interface #290

Merged
merged 5 commits into from
Dec 2, 2024

Conversation

iFergal
Copy link
Contributor

@iFergal iFergal commented Nov 8, 2024

To accompany WebOfTrust/keria#318.

Just putting to for review now as I'm just about to go on holidays for a week but when back if we want to merge we'll need a new dev release on KERIA, which I can give a go at doing now.

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.63%. Comparing base (07abd31) to head (cba180b).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #290      +/-   ##
==========================================
+ Coverage   83.59%   83.63%   +0.03%     
==========================================
  Files          48       48              
  Lines        4225     4235      +10     
  Branches     1055     1029      -26     
==========================================
+ Hits         3532     3542      +10     
- Misses        663      689      +26     
+ Partials       30        4      -26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@lenkan lenkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lenkan lenkan merged commit e8a4047 into WebOfTrust:main Dec 2, 2024
8 checks passed
@iFergal iFergal deleted the feat/agentConfig branch December 2, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants