chore: enforce the recommended linting rules for some files #279
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought we should make an effort to remove the relaxed linting rules. This is an initial effort to work towards enforcing the recommended linting rules for all files.
The changes to the lint config explicitly specifies the files that should have relaxed rules. The idea is that this list should eventually be removed once the entire codebase conforms to the rules.
In this PR I have only fixed some low hanging fruit in the test directory. If people think it is a good idea to enforce the rules I can do it for the rest. I would do it in my spare time so it might take a few weeks to do the overhaul.
In the long term, I think we will benefit greatly by getting rid of all the
any
types in the code base. Strict types will make it much easier to catch type errors and also improve the discoverability of the library.