Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple healthcheck #97

Closed
wants to merge 1 commit into from
Closed

Conversation

kentbull
Copy link
Contributor

Useful for Kubernetes readinessProbe and livenessProbe

@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Merging #97 (249522a) into development (05c7eab) will decrease coverage by 0.04%.
Report is 6 commits behind head on development.
The diff coverage is 66.66%.

❗ Current head 249522a differs from pull request most recent head da446a9. Consider uploading reports for the commit da446a9 to get more accurate results

@@               Coverage Diff               @@
##           development      #97      +/-   ##
===============================================
- Coverage        88.20%   88.16%   -0.04%     
===============================================
  Files               30       30              
  Lines             4789     4792       +3     
===============================================
+ Hits              4224     4225       +1     
- Misses             565      567       +2     
Files Changed Coverage Δ
src/keria/app/agenting.py 81.11% <66.66%> (-0.21%) ⬇️

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@pfeairheller pfeairheller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the broken tests and this will be good to go. A simple "is alive" on the boot interface is fine for now.

Useful for Kubernetes readinessProbe and livenessProbe
@kentbull
Copy link
Contributor Author

looks like I'm hitting a merge conflict because of the recent changes on development. I'll close this PR and open a new once since I'm using the commit this particular branch branched off of in another context.

@kentbull kentbull closed this Sep 11, 2023
@kentbull
Copy link
Contributor Author

kentbull commented Dec 7, 2023

#144 addresses this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants