Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: docker image reference cannot contain uppercase characters #311

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

lenkan
Copy link
Collaborator

@lenkan lenkan commented Oct 18, 2024

Using WebOfTrust/keria as the image name causes docker to choke and try to publish to a docker registry hosted at WebOfTrust instead of docker.io. This is what happened here: https://github.com/WebOfTrust/keria/actions/runs/11315384968/job/31466498211

Closes #309

Read more here: https://docs.docker.com/reference/cli/docker/image/tag/

PATH: The path consists of slash-separated components. Each component may contain lowercase letters, digits and separators. A separator is defined as a period, one or two underscores, or one or more hyphens. A component may not start or end with a separator. While the OCI Distribution Specification supports more than two slash-separated components, most registries only support two slash-separated components. For Docker's public registry, the path format is as follows:

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.74%. Comparing base (18d3ad7) to head (be40c0d).
Report is 27 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #311      +/-   ##
==========================================
+ Coverage   93.06%   93.74%   +0.68%     
==========================================
  Files          36       36              
  Lines        7121     7979     +858     
==========================================
+ Hits         6627     7480     +853     
- Misses        494      499       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pfeairheller pfeairheller merged commit 5f9d6d6 into WebOfTrust:main Oct 22, 2024
5 checks passed
@lenkan lenkan deleted the fix-docker-image-tag branch October 22, 2024 15:13
@iFergal
Copy link
Collaborator

iFergal commented Oct 28, 2024

@2byrds can we try a dev release again now that this is merged?

@2byrds
Copy link
Collaborator

2byrds commented Oct 28, 2024

@2byrds can we try a dev release again now that this is merged?

@iFergal what do you want the version to be?

@iFergal
Copy link
Collaborator

iFergal commented Oct 28, 2024

@2byrds 0.2.0-dev4 makes sense to me since I guess we haven't moved to the new released keripy version yet (#300)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix docker tag repo pointer in github action
5 participants