Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowing prefixes in identifiers endpoint (resubmitted PR) #269

Merged
merged 16 commits into from
Aug 21, 2024

Conversation

rodolfomiranda
Copy link
Collaborator

This PR is resubmitted version of the canceled #264
It's is an implementation of #217 and #202, fixing the problem of aliases with special characters .
The changes allow endpoints of the form /identifiers/{name} to accept an alias or a prefix in the name path. If the value is valid for both prefix and alias, the prefix is prioritized.
Basically, the PR replace:
hab = agent.hby.habByName(name)
with
hab = agent.hby.habs[name] if name in agent.hby.habs else agent.hby.habByName(name)

Copy link

codecov bot commented Jul 12, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 93.17%. Comparing base (18d3ad7) to head (57f9f0f).
Report is 13 commits behind head on main.

Files Patch % Lines
src/keria/app/aiding.py 88.88% 2 Missing ⚠️
src/keria/app/credentialing.py 90.00% 1 Missing ⚠️
src/keria/app/delegating.py 50.00% 1 Missing ⚠️
src/keria/app/grouping.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #269      +/-   ##
==========================================
+ Coverage   93.06%   93.17%   +0.11%     
==========================================
  Files          36       36              
  Lines        7121     7741     +620     
==========================================
+ Hits         6627     7213     +586     
- Misses        494      528      +34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pfeairheller pfeairheller self-requested a review July 16, 2024 14:07
2byrds

This comment was marked as resolved.

@rodolfomiranda rodolfomiranda requested a review from 2byrds August 21, 2024 13:42
@2byrds 2byrds merged commit fe2c2a5 into WebOfTrust:main Aug 21, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants