Support for https endpoints #103
Conversation
Codecov Report
@@ Coverage Diff @@
## development #103 +/- ##
===============================================
+ Coverage 88.20% 89.70% +1.50%
===============================================
Files 30 34 +4
Lines 4789 5257 +468
===============================================
+ Hits 4224 4716 +492
+ Misses 565 541 -24
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| @@ -889,31 +888,34 @@ def on_get(req, rep, alias): | |||
| if role in (kering.Roles.witness,): # Fetch URL OOBIs for all witnesses | |||
| oobis = [] | |||
| for wit in hab.kever.wits: | |||
| urls = hab.fetchUrls(eid=wit, scheme=kering.Schemes.http) | |||
| urls = hab.fetchUrls(eid=wit, scheme=kering.Schemes.http) or hab.fetchUrls(eid=wit, scheme=kering.Schemes.https) | |||
There was a problem hiding this comment.
should add a test to cover this branch in logic
There was a problem hiding this comment.
Agreed. We don't have coverage of that branch. In order to fully test that branch it seems we need to bring in locally self signed certificates for proper TLS. I could bring that in from HIO like I mentioned. Would you still prefer mocking in this case? We'd just need a hab with TLS urls. I'm not familiar with the test fixtures though I suppose there is a Hab test fixture pretty close to what we need.
There was a problem hiding this comment.
Yeah, looks like we'll need a new helpers.openKeria() test fixture that returns an agency started up with TLS config. Want me to make that for this PR?
|
The main difference between these two PRs was the usage of |
|
I'm closing this PR since all the changes were included in PR #102 |
|
I'm closing this PR since all the changes were included in PR #102 |
This PR replace PR #91 due branch inconsistencies after moving from main to development.