Skip to content

Commit

Permalink
revert local override on no_fdflags_sync_support
Browse files Browse the repository at this point in the history
* I couldn't find this in wasmtime repo. I suppose this was
  a local modification done as a part of
  #68

* As some implementations have implemented it, it isn't appropriate
  to assert NOTSUP by default.
  • Loading branch information
yamt authored and loganek committed Oct 5, 2023
1 parent 2ea824c commit 671aaab
Showing 1 changed file with 1 addition and 5 deletions.
6 changes: 1 addition & 5 deletions tests/rust/src/config.rs
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,7 @@ impl TestConfig {
let no_dangling_filesystem = std::env::var("NO_DANGLING_FILESYSTEM").is_ok();
let no_fd_allocate = std::env::var("NO_FD_ALLOCATE").is_ok();
let no_rename_dir_to_empty_dir = std::env::var("NO_RENAME_DIR_TO_EMPTY_DIR").is_ok();

// Disable the sync tests while we determine whether these will be
// included in the standard: <https://github.com/WebAssembly/wasi-filesystem/issues/98>
//let no_fdflags_sync_support = std::env::var("NO_FDFLAGS_SYNC_SUPPORT").is_ok();
let no_fdflags_sync_support = true;
let no_fdflags_sync_support = std::env::var("NO_FDFLAGS_SYNC_SUPPORT").is_ok();

TestConfig {
errno_mode,
Expand Down

0 comments on commit 671aaab

Please sign in to comment.