Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for type annotations on array.len #6197

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

tlively
Copy link
Member

@tlively tlively commented Jan 3, 2024

These type annotations were removed during the development of the GC proposal,
but we maintained support for parsing them to ease the transition. Now that GC
is shipped, remove support for the non-standard annotation and update our tests
accordingly.

@tlively tlively requested a review from kripken January 3, 2024 08:09
Base automatically changed from parser-folded-fix to main January 3, 2024 20:55
These type annotations were removed during the development of the GC proposal,
but we maintained support for parsing them to ease the transition. Now that GC
is shipped, remove support for the non-standard annotation and update our tests
accordingly.
@tlively
Copy link
Member Author

tlively commented Jan 3, 2024

Merge activity

  • Jan 3, 3:55 PM: Graphite rebased this pull request as part of a merge.
  • Jan 3, 4:36 PM: @tlively merged this pull request with Graphite.

@tlively tlively merged commit c923521 into main Jan 3, 2024
15 checks passed
@tlively tlively deleted the no-array-len-annotation branch January 3, 2024 21:36
radekdoulik pushed a commit to dotnet/binaryen that referenced this pull request Jul 12, 2024
These type annotations were removed during the development of the GC proposal,
but we maintained support for parsing them to ease the transition. Now that GC
is shipped, remove support for the non-standard annotation and update our tests
accordingly.
@gkdn gkdn mentioned this pull request Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants