Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/pass smart account config #2053

Merged
merged 3 commits into from
Jan 15, 2025
Merged

Feat/pass smart account config #2053

merged 3 commits into from
Jan 15, 2025

Conversation

lionellbriones
Copy link
Contributor

Motivation and Context

  • pass smart account config to wallet service

Jira Link:
https://toruslabs.atlassian.net/browse/PD-4338

Description

How has this been tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project. (run lint)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code requires a db migration.

@vercel Vercel
Copy link

vercel bot commented Jan 14, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web3auth-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 15, 2025 10:04am

@lionellbriones lionellbriones marked this pull request as draft January 14, 2025 14:48
@lionellbriones lionellbriones marked this pull request as ready for review January 15, 2025 09:59
chaitanyapotti
chaitanyapotti approved these changes Jan 15, 2025
View reviewed changes
Copy link
Member

@chaitanyapotti chaitanyapotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chaitanyapotti chaitanyapotti merged commit 76d3837 into master Jan 15, 2025
5 checks passed
@chaitanyapotti chaitanyapotti deleted the feat/pass-smart-account-config branch January 15, 2025 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaitanyapotti chaitanyapotti chaitanyapotti approved these changes

@tanguyenvn tanguyenvn Awaiting requested review from tanguyenvn

@tuna1207 tuna1207 Awaiting requested review from tuna1207

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lionellbriones @chaitanyapotti