Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RPC errors #328

Merged
merged 2 commits into from
Aug 10, 2024
Merged

Add RPC errors #328

merged 2 commits into from
Aug 10, 2024

Conversation

chaitanyapotti
Copy link
Member

@chaitanyapotti chaitanyapotti commented Aug 9, 2024

Motivation and Context

@metamask/rpc-errors has an issue when bundling with vite. we export our own version which has better bundling support.

Jira Link:

Description

This pull request adds RPC errors to the codebase. The changes include exporting error constants, error classes, and utility functions related to errors. No specific issue is being fixed with this pull request.

How has this been tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project. (run lint)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Contributor

@arch1995 arch1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chaitanyapotti chaitanyapotti merged commit 9bccf5f into v8 Aug 10, 2024
1 check passed
@chaitanyapotti chaitanyapotti deleted the feat/rpc-errors branch August 10, 2024 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants