Merge pull request #1153 from WeBankPartners/1142_proc_enc

#1142 fix tiny bug as to guid
WeBankPartners · Oct 29, 2020 · 9ca6382 · 9ca6382
2 parents ce9702b + 556a05a
commit 9ca6382
Showing 1 changed file with 1 addition and 3 deletions.
diff --git a/cmdb-plugin/src/main/java/com/webank/plugins/wecmdb/service/WecubeAdapterService.java b/cmdb-plugin/src/main/java/com/webank/plugins/wecmdb/service/WecubeAdapterService.java
@@ -405,10 +405,9 @@ public List<Map<String, Object>> updateCiDataByGuid(List<OperateCiDataUpdateDto>
 
             if (StringUtils.isBlank(operateCiDataUpdateDto.getGuid())) {
                 String errorMessage = "Field 'guid' is required for CI data update.";
-                resultItem.put(ERROR_CODE, SUCCESS);
+                resultItem.put(ERROR_CODE, FAIL);
                 resultItem.put(ERROR_MESSAGE, errorMessage);
                 results.add(resultItem);
-                return;
             }
 
             String guid = operateCiDataUpdateDto.getGuid();
@@ -426,7 +425,6 @@ public List<Map<String, Object>> updateCiDataByGuid(List<OperateCiDataUpdateDto>
                 resultItem.put(ERROR_MESSAGE, errorMessage);
                 exceptionHolders.add(new ExceptionHolder(operateCiDataUpdateDto.getCallbackParameter(), operateCiDataUpdateDto, errorMessage, null));
                 results.add(resultItem);
-                return;
             }
         });