Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install.sh Support single leading tilde in prefix (without using eval, replacement for #24) #26

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SuzanneSoy
Copy link
Contributor

See #24 for details; this method does not use eval and shouldn't have problems with other special characters than ~ (it doesn't support ~username or a lone ~, adding those would be easy but they are unlikely to be used in practice.

@soreau
Copy link
Member

soreau commented Mar 10, 2021

See #24 for details; this method does not use eval and shouldn't have problems with other special characters than ~ (it doesn't support ~username or a lone ~, adding those would be easy but they are unlikely to be used in practice.

Might as well fix these potential cases while you're at it since they are known 'gotchas'.

@SuzanneSoy
Copy link
Contributor Author

I'm busy right now but I'm making a note to fix the conflicts and the other ~ use cases this weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants