Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: did precompile DOS attack #158

Merged
merged 2 commits into from
Sep 28, 2023
Merged

test: did precompile DOS attack #158

merged 2 commits into from
Sep 28, 2023

Conversation

Moliholy
Copy link
Collaborator

No description provided.

@Moliholy Moliholy requested a review from peterwht September 26, 2023 10:43
@Moliholy Moliholy self-assigned this Sep 26, 2023
peterwht
peterwht suggested changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@peterwht peterwht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! Just a couple reverts to the explicit type declaration and it's good to merge.

precompiles/did/src/lib.rs Outdated Show resolved Hide resolved
precompiles/did/src/lib.rs Outdated Show resolved Hide resolved
@Moliholy
Copy link
Collaborator Author

I also opened an issue requesting a better interface for BoundedVec in paritytech/parity-common#791.

@Moliholy Moliholy merged commit 85b80f9 into main Sep 28, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterwht peterwht peterwht approved these changes

Assignees

@Moliholy Moliholy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Moliholy @peterwht