Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doomhammer artifact #884

Merged
merged 15 commits into from
Dec 15, 2024
Merged

Doomhammer artifact #884

merged 15 commits into from
Dec 15, 2024

Conversation

arithon
Copy link
Contributor

@arithon arithon commented Feb 8, 2022

Changelog:

  • Added the doomhammer with stats based on what we gave it in the ck2 mod.
  • Icon added
  • Model added
  • history of the artifact added

grafik

Balancing Spreadsheet:
https://docs.google.com/spreadsheets/d/18zS-FAte6nsejx7rpzSmVuioRXps3iWSvSkx_xRJSWI/edit#gid=1165316868

@arithon arithon changed the title Creation of the doomhammer (pics needed) Doomhammer artifact Feb 8, 2022
@arithon arithon self-assigned this Feb 8, 2022
@arithon arithon added lore 📚 Comes from lore new feature ⭐ Involves adding new feature that affects game labels Feb 8, 2022
@ElMariuso
Copy link
Contributor

You should merge that in 1.5.0 preview for the moment.

@MemeWizard MemeWizard changed the base branch from master to 1.5.0-preview-adaptation February 8, 2022 23:09
@MemeWizard MemeWizard changed the base branch from 1.5.0-preview-adaptation to frostmourne February 9, 2022 00:25
@arithon arithon added the artifact⚔️ Involves artifacts label Feb 15, 2022
@TheKarma003 TheKarma003 marked this pull request as ready for review September 12, 2022 19:40
@TheKarma003 TheKarma003 deleted the Doomhammer branch September 12, 2022 20:37
@TheKarma003 TheKarma003 restored the Doomhammer branch September 12, 2022 20:39
@arithon arithon reopened this Sep 14, 2022
Base automatically changed from frostmourne to master March 19, 2023 14:04
@arithon arithon added localisation 📄 This issue or pull request supposes localization changes localisation - german 📄 This issue or pull request supposes changes to German localization 2D graphics 🖌️ Involves tweaking/adding 2D arts 3D graphics 📐 Involves tweaking/adding 3D models labels May 15, 2023
@Chomski2 Chomski2 changed the base branch from master to dev September 5, 2024 14:04
@Chomski2 Chomski2 self-assigned this Sep 5, 2024
@Rimaka94 Rimaka94 self-requested a review December 15, 2024 04:02
Copy link
Contributor

@Rimaka94 Rimaka94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved from ingame testing pov.

Doomhammer artifact has classic model when spawned in as a non-Thrall or non-Frostwolf character, which is always Orgrim Doomhammer. (Currently, Doomhammer does not change models when it changes hands to Thrall or a Frostwolf culture. Per discussion in ck3-testing, this is currently expected and further dev work will be required to flip the model.)

Doomhammer artifact has frostwolf model when spawned in with Thrall or Frostwolf character, which currently is always Thrall in the two later bookmarks.

Stats are applied correctly, and model is applying correctly in duels.

@ElMariuso ElMariuso merged commit a7cfa39 into dev Dec 15, 2024
1 check failed
@ElMariuso ElMariuso deleted the Doomhammer branch December 15, 2024 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2D graphics 🖌️ Involves tweaking/adding 2D arts 3D graphics 📐 Involves tweaking/adding 3D models artifact⚔️ Involves artifacts localisation - german 📄 This issue or pull request supposes changes to German localization localisation 📄 This issue or pull request supposes localization changes lore 📚 Comes from lore new feature ⭐ Involves adding new feature that affects game
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants