Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Dark Crystal Artifact Generation On Combat Victory Versus Orcish Fel Army With Caster_Unit MAA #1611

Closed
wants to merge 2 commits into from

Conversation

socratespandagoa
Copy link

Adds a combat event triggered on victory versus Orcish Fel army with caster_unit MAA (historical_artifacts.200). This event triggers a second one (201) that generates the Dark Crystal.

Changelog:

  • Add Events: historical_artifacts.201 and historical_artifacts.200
  • Added historical_artifacts.200 to on_combat_end_winner trigger
  • Locked Dark_Crystal artifact benefits to faiths that allow or approve shadow magic
  • Included .dds files for Dark_Crystal, Ashbringer, and Corrupted Ashbringer

How to test: Start as Stormwind in the first bookmarked startdate and win a battle against a draenor invasion army with caster_unit maa. Winning triggers an event that leads to generating the dark crystal artifact. Make sure the NPC you can recruit from the third option ends up in your court.

Adds a combat event triggered on victory versus Orcish Fel army with caster_unit MAA (historical_artifacts.200). This event triggers a second one (201) that generates the Dark Crystal.
Removed Ashbringer files and code to more safely test Dark Crystal

trigger = {

}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove this, the trigger was on the previous event

# 1, Realm Priest
if = {
limit = {
exists = realm_priest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scope:realm_priest

@socratespandagoa socratespandagoa deleted the Dark-Crystal branch December 18, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants