Horde Invasion Flavor #1586
Horde Invasion Flavor #1586
Conversation
shitty update Update cleanup removing aegwynn version small update post merge adaptation Placeholders TODO Reorganization Assault on Stormwind Placeholder test feature I don't think it's a good idea Blackhand and Gul'dan placeholders Fuck you Guldan Other placeholders more Twilight's Hammer event part 1 some stuff for mariuso More structure
There was a problem hiding this comment.
Test Criteria
✅ Dragonmaw clan is landed under the Horde and working as expected.
✅ Burning Blade clan is adventurer and working as expected.
✅ No new issues from syntax uniformization
✅ "Opening of the Dark Portal" notification is working as expected for different POVs
✅ Introductory events working as expected for Blackhand, Gul'dan, Durotan, Orgrim, Kilrogg, Cho'gall and other Twilight's Hammer members
✅ AI properly does not choose non-canon paths.
✅ "Twilight Canticle" artifact is in game and working as expected.
✅ Special event for declaring the First War works as expected.
✅ No new relevant errors in error.log (I didn't find anything, but would suggest others to check as well to make sure)
Marks:
✅ - working as expected
❌ - not working as expected
🔶 - may or may not be an issue, noted for your discretion
In-depth Testing
🪓 Orc Starts
- ✅ Blackhand
- ✅
Conqueror of New Landscharacter modifier no longer has missing localization.
- ✅
- ✅ Orgrim
- ✅ Option A for Orgrim's introductory event now looks proper and makes sense with Durotan losing -30 opinion.
- ✅
Path to Glorycharacter modifier is no longer missing localization.
- ✅ Cho'gall
- ✅ Twilight Canticle artifact can now be equipped to gain the bonuses stated when not fulfilling all requirements.
- ✅ Twilight Canticle new icon looks great.
- ✅ Burning Blade
- ✅ Camp is now located in Dark Mire under the Horde at the start.
- ✅ War declaration event is now properly firing for the correct character despite who controls the Horde. If Blackhand somehow loses the title prior to the new firing date of 31 February, the new leader will have the event fire at a later time for the correct scope.
🛡️ Other Starts
- ✅
wc_horde_invasion.1000.stormwind_kingchoice localization looks better now as "We should investigate."
Additional comments
- ✅ AI Orgrim Doomhammer is no longer usurping the Horde title from Blackhand.
- ✅ If for some crazy case Orgrim Doomhammer (or any other character) does usurp the Horde title before it fires, the war event will now fire a few months later and from the new correct scope.
All points from my previous test have been addressed and I have found no further issues at this time, so I'm leaving my approval.
There was a problem hiding this comment.
One final review to go over new content since my last review.
All new changes reviewed and detailed below:
✅ Doomhammer artifact integration
- If Orgrim loses Doomhammer prior to January 8 introductory event, the event description/option text are now proper.
✅ Localization
- Holyoak gloss working as expected for Stormwind POV wc_horde_invasion.9000
✅ Horde War Declaration Restriction
- Restriction on Horde title from declaring war until scripted Stormwind war event pops is working as expected, with relevant bugs squashed per our discussion in discord #horde-invasion-flavor, such as the restriction following title changing hands.
✅ Cho'gall Introductory Event
- Issue with AI weight of both options at 0 addressed. AI Cho'gall now picks canon option everytime.
LGTM
Changelog:
Tests:
wcfiles inDocuments\Paradox Interactive\Crusader Kings III\logs\error.logexceptportrait_decals.cpp:101How to test: