Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arcane Scrying Tenet #1294

Closed
wants to merge 820 commits into from
Closed

Arcane Scrying Tenet #1294

wants to merge 820 commits into from

Conversation

edmund-h
Copy link
Contributor

Changelog:

  • Removed the Astrology tenet, as it's underpowered and doesn't represent anything useful in the Warcraft universe.
  • Replaced it with the Arcane Scrying trait which provides additional protection from random events and improves relations with other arcane magic users without rising to the level of a syncretism trait
  • Removed it from the Lightforged as it is no longer compatible with their magic laws and replaced with Monasticism.
  • Replaced all other instances of Astrology with Arcane Scrying, ensuring that magic laws allowed arcane magic.

Tests:

  • There are no errors in wc files in Documents\Paradox Interactive\Crusader Kings III\logs\error.log except portrait_decals.cpp:101
  • The mod takes less than 5.5 GB in the Task Manager (Windows)

How to test:

@MemeWizard
Update window_character_lifestyle.gui
716c574 
GDC
@MemeWizard
Merge pull request #753 from Warcraft-GoA-Development-Team/uncommente…
d79e47c 
…d-physical-traits

Uncommented physical traits
@MemeWizard
Merge pull request #731 from Warcraft-GoA-Development-Team/history_ad…
c6bb6f5 
…ding_perks

Adding perks for historical characters
@MemeWizard
Merge pull request #633 from Warcraft-GoA-Development-Team/auto_selec…
4a6ae0d 
…tion_weight-fix

Auto selection weight fix
@MemeWizard
Merge pull request #760 from Warcraft-GoA-Development-Team/knowledge-…
85405d1 
…overflow-magic-adaptation

Knowledge overflow adaptation for mod lifestyles
@MemeWizard
Update wc_mana_effects.txt
e701454 
GDC
@MemeWizard
ranamed gui file
5005632 
GDC
@MemeWizard
Create wc_elemental_progressbars.gui
7b46237 
GDC
@MemeWizard
Custom loc updated
3ca47c5 
GDC
@MemeWizard
Merge branch 'changed-elemental-doctrines' into magic-trees-new-doctr…
37d41e3 
…ines-adaptation

# Conflicts:
#	common/religion/religions/air_group.txt
#	common/religion/religions/arcane_group.txt
#	common/religion/religions/avian_group.txt
#	common/religion/religions/deathbringer.txt
#	common/religion/religions/doombringer.txt
#	common/religion/religions/earth_group.txt
#	common/religion/religions/fel_group.txt
#	common/religion/religions/fire_group.txt
#	common/religion/religions/light_group.txt
#	common/religion/religions/necromancy_group.txt
#	common/religion/religions/void_group.txt
#	common/religion/religions/water_group.txt
#	localization/english/religion/wc_magic_doctrines_l_english.yml
@MemeWizard
Merge branch 'changed-elemental-doctrines' into magic-trees-new-doctr…
b649988 
…ines-adaptation
@MemeWizard
Update wc_lifestyle_traits.txt
b5d7433 
GDC
@MemeWizard
Update wc_lifestyles_values.txt
436d743 
GDC
@MemeWizard
Update wc_magic_lifestyles_window_character_lifestyle_l_english.yml
71020a1 
GDC
@MemeWizard
finished(?) gui
67c8576 
GDC
@MemeWizard
Merge branch 'magic_trees' into magic-trees-new-doctrines-adaptation
eff9c4c
@MemeWizard
Focus tooltip fix
ee22765 
GDC
@MemeWizard
error fix
8015bdd 
GDC
@MemeWizard
Update wc_lifestyles_custom_loc.txt
1b979c1 
GDC
@MemeWizard
Update wc_game_concepts_l_english.yml
e056e87 
GDC
@MemeWizard
Update wc_lifestyles_physical_l_english.yml
44f8487 
GDC
@MemeWizard
Update wc_lifestyles_magic_l_english.yml
36827b9 
GDC
@MemeWizard
Update wc_lifestyles_magic_l_english.yml
e4ef640 
GDC
@MemeWizard
concepts updated
2ff5201 
GDC
@MemeWizard
Update wc_lifestyles_values.txt
7c7fda2 
GDC
@MemeWizard
Update wc_game_concepts_lifestyles_l_english.yml
4d161a2 
GDC
@MemeWizard
Update window_character_lifestyle.gui
88f6bce
@MemeWizard
Update wc_traits_lifestyles_l_english.yml
ac2d6f2 
GDC
@MemeWizard
added 1/4 element localization
21af11f 
GDC
@MemeWizard
other 3/4 elemental localization
39324a4 
GDC
edmund-h and others added 27 commits January 17, 2024 14:20
@edmund-h
fix errors with localization
c1db834
@edmund-h
Merge pull request #1340 from Warcraft-GoA-Development-Team/magic_secret
7f45cda 
Magic secret
@Grekopithikos
Man'ari creature trait (#1352)
55aaeea
@helloruhe
Merge branch 'master' into magic-2024
b4e8000
@helloruhe
secrets integration
ee058e3
@helloruhe
Merge branch 'dev' into magic-2024
8f20de8
@edmund-h
fix error preventing non-e magic from 5 rank
ad5bb67
@edmund-h
re-enable ruler leveled trait
632c541
@Raged50
Mogu ethnicity (#1345)
d743407 
* disable stone portrait for mogu

* Update wc_ethnicities_mogu.txt
@edmund-h
remove rulter trait from main working branch
5b65547
@helloruhe
magical prowess + remove focus button
99733b0
@helloruhe
more magical prowess stuff
9d6fd2c
@edmund-h
fix errors but keep secret triggers separate
4bd8f4d
@helloruhe
Fertility Gamerule (#1347)
efd916e 
* Merge branch 'master' of https://github.com/Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth-2

* bugfix
@edmund-h
remove loc and code for s/d magic from m_l.7000
2b6ba8b
@edmund-h
erase rest of s/d ele magic secret references
f02abfb
@edmund-h
additional magic secrets fixes
d9eb559
@helloruhe
Merge branch 'dev' into magic-2024
92de253
@helloruhe
hide secret mp + mana regen
3afce4e
@helloruhe
gui fix as needed
2a1f6a1
@helloruhe
commit
ce8c4c1
@edmund-h
add scrollarea to perk trees
6ba1edb
@edmund-h
move lifestyle trees and rename
b0b1292
@edmund-h
small fixes to moved trees
9805222
@Myphicbowser
Removes Superfluous Code
29721d8 
Removes all trait=user_of_x_magic_y on character files, as they are now added automagically
@edmund-h
replace astrology with new trait + loc fixes
42b1ca3
@edmund-h
add icon, change how old tenet was removed
7e2c24f
@edmund-h edmund-h force-pushed the arcane_scrying_tenet branch from c325d90 to 7e2c24f Compare February 16, 2024 23:47
@edmund-h edmund-h closed this Feb 16, 2024
@edmund-h
Copy link
Contributor Author

this will be moved to Magic 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Grekopithikos Grekopithikos Grekopithikos left review comments

Assignees

@edmund-h edmund-h

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@edmund-h @helloruhe @Grekopithikos @MemeWizard @sumankun @Raged50 @Myphicbowser