Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix 0.4.1 #1293

Merged
merged 32 commits into from
Dec 26, 2023
Merged

hotfix 0.4.1 #1293

merged 32 commits into from
Dec 26, 2023

Conversation

sumankun
Copy link
Contributor

@sumankun sumankun commented Dec 23, 2023

New:

  • alternate universe gamerule
  • some perks affect the (de)centralization of a union
  • first created theramorean kingdom also gets the theramore name and coa

Fixes:

  • fixed error.log
  • updated union game concept
  • shortened bookmark description for multiplayer (people with 1920x1080 couldnt press play)
  • capitalized new paragraphs in kalimdor events
  • fixed children being born undead if culture has undead heritage
  • draeneis can get the gift of Naaru with enough piety level (previously only 5 spawned ones had it)
  • added fallback to fix bug, if some person somehow in two unions
  • capitalized theramore modifiers' names
  • removed new headgears/clothes for static races in barbershop
  • arthas gets penalty opinion from Terenas during disinheritance
  • ai requires duchy level to take a loan, to not spam
  • dark portal decision fixed, no endless repeating event in first bookmark
  • missing loc for ears in ruler designer, and fixed some other locs
  • union members can call each other into wars and make a gift, ignoring diplorange
  • you also ignore diplorange for inviting into union interaction after certain year (608.1.1)
  • (probably)fixed too big amount of union members for players
  • unions apply colors from game rule only after lobby start
  • fixed some icons dds format
  • members of theramore expedition end their own wars(or leave as allies) when get land in theramore

Tests:

  • There are no errors in wc files in Documents\Paradox Interactive\Crusader Kings III\logs\error.log

@sumankun sumankun marked this pull request as ready for review December 25, 2023 20:46
Copy link
Contributor

@ElMariuso ElMariuso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[00:39:34][jomini_script_system.cpp:276]: Script system error!
  Error: add_title_law effect [ Failed to add law:
Law is invalid for current holder ]
  Script location: file: common/scripted_effects; clan_setup_effect line: 4
 file: events/story_cycles/wc_story_cycle_horde_invasion_events.txt line: 426
 file: common/scripted_effects; invite_burning_blade_effect line: 25

[00:39:34][jomini_script_system.cpp:276]: Script system error!
  Error: add_title_law effect [ Failed to add law:
Law is invalid for current holder ]
  Script location: file: common/scripted_effects; clan_setup_effect line: 4
 file: events/story_cycles/wc_story_cycle_horde_invasion_events.txt line: 427
 file: common/scripted_effects; invite_dragonmaw_effect line: 26

I have constantly this error, what do you think ?

Copy link
Contributor

@ElMariuso ElMariuso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM so

@sumankun sumankun merged commit 6dbd40f into master Dec 26, 2023
@sumankun sumankun deleted the hotfix-0-4-1 branch December 26, 2023 00:17
@sumankun sumankun added this to the 0.4.1 Release Alpha milestone Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants