Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

holy light uther stuff #1291

Closed
wants to merge 13 commits into from
Closed

Conversation

helloruhe
Copy link
Contributor

@helloruhe helloruhe commented Dec 20, 2023

This reverts commit afca855.

Changelog:

  • Added Uther to the Expedition Activity and made him a bit more involved (players only mechanic)
  • Changed that thing.

Developer changelog:

  • Added this thing.
  • Changed that thing.

Tests:

  • There are no errors in wc files in Documents\Paradox Interactive\Crusader Kings III\logs\error.log except portrait_decals.cpp:101
  • The mod takes less than 5.5 GB in the Task Manager (Windows)

How to test:

in the expedition event:

  • play as arthas, do all 3 choices, make sure activity doesnt break. you should not get an event popup about changing your decision or whatever.
  • play as jaina, make sure activity doesnt break
  • play as uther, do all 3 arthas choices (using game rule), if arthas does not want to plague, you should not get an option to convince hiim otherwise. if you end up winning the battle to convince him (you can temporarily change the code to make it guaranteed, i added rng so its different everytime.), he should actually change the course of action and not just go along with the purge (unless he betrays you, which will be shown)
  • make sure you can find uther to join the activity whether he is landed or not. will most likely find him if landed but test when he is unlanded
  • do whatever else you think seems appropriate

note:

if arthas decides not to purge the city, but his original intent was to go to northrend, he should still be going to northrend regardless. idk if i should change his entire course of action, but i decided not to initally because its more likely to break the event, and mess up player choice

localization/english/wc_uther_events_l_english.yml Outdated Show resolved Hide resolved
localization/english/wc_uther_events_l_english.yml Outdated Show resolved Hide resolved
localization/english/wc_uther_events_l_english.yml Outdated Show resolved Hide resolved
localization/english/wc_uther_events_l_english.yml Outdated Show resolved Hide resolved
localization/english/wc_uther_events_l_english.yml Outdated Show resolved Hide resolved
localization/english/wc_uther_events_l_english.yml Outdated Show resolved Hide resolved
localization/english/wc_uther_events_l_english.yml Outdated Show resolved Hide resolved
localization/english/wc_uther_events_l_english.yml Outdated Show resolved Hide resolved
@helloruhe helloruhe marked this pull request as ready for review January 14, 2024 15:19
Copy link
Contributor

@Myphicbowser Myphicbowser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The two other actions (Stay in Lorderaon/Join Jaina in Theramore) both work well for Jaina and Uther, however after the decision is made the part about Arthas going to Northrend triggers six times, providing Prestige and such during it, and then the event instantly ends after a few days of that being handled

Beyond this, everything else works
I used the Game Rule to force Arthas' other choices while playing as Jaina and Uther

@helloruhe helloruhe closed this Jan 15, 2024
@robmart robmart deleted the more-uther-stuff branch August 3, 2024 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants