Professions: Blacksmithing & Mining #1287
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Dec 18, 2023
Open
Open
edmund-h
reviewed
Dec 25, 2023
edmund-h
reviewed
Dec 29, 2023
| limit = { reagent_rarity_is_rare_trigger = { REAGENT = $REAGENT$ } } | ||
| value = 5 | ||
| } | ||
| if = { |
There was a problem hiding this comment.
shouldn't these be else_ifs? a reagent can't be rare and uncommon at the same time can it?
edmund-h
reviewed
Dec 29, 2023
Grekopithikos
added
the
new feature ⭐
* Switch all being assignment to using culture gfx * Kvaldir assignment * Remove demonic flag, it's not needed * Remove age boost to plants, being_life already gets a boost * Remove unneeded check * Remove unneeded check * Remove unneeded check
* Initial commit * some grammatical changes to old god possessives * revise english localization for dark pluralism doctrine --------- Co-authored-by: Edmund <[email protected]>
* wc_arthas_story_50 tooltip fix * a * a * lich king notification someone yoinked frostmourne * aa * aa * Update wc_scourge_quelthalas_effects.txt * Fire the effect * Change commence_scourge_quelthalas_effect region check * a * Fix * removing lordaeron notification from arthas_story, adding to separate decision * remove quelthalas event chain starter from arthas story * require frostmourne to start decision * Create wc_scourge_quelthalas_decisions.txt * reduce requirements * event update * loc fix * decision update * test * additional scope * Update wc_scourge_quelthalas_events.txt * event two * offer to quelthalas vassals * Update wc_scourge_quelthalas_events.txt * Change Arthas inheritance and order of Quel events * Revamp Lordaeron inheritance again * Add pressed claim to e_lordaeron * prince dark'khan actually betrays quelthalas most of the time * localisation for fealty events * Update wc_scourge_quelthalas_events.txt * End war properly and fix some errors * scourge invasion of quelthalas cb * event war update * fix * war cb * Lordaeron always gets broken * Calia always gets e_lordaeron claim * war tweaks * End the correct war * Turn Lordaeron undead * conversion from sc_scourge_qualthalas_effect to event chain * Turn conquered vassals undead * Better handling of quel war victory * Turn *everyone* undead * Also applies to Lordaeron * Modifier to block union * Inheritable union block modifier * Block Lor'themar from union on later start date * San'layn High Elf variant * Should be Darkfallen * darkfallen loc * big flavour text * notification events * Update wc_scourge_quelthalas_events.txt * Make sure no foreign rulers are made undead * Fix * Prevent characters with plot armor from being raised * Add missing equal signs * sylvanas banshee event * Fix Sylvanas event * Frostmourne is not instantly maxed * Union block is removed correctly * Equip Frostmourne automatically * oh no * Convert recipient properly * Union block modifier loc * sylvanas and arthas perspective * Basic corrupted sunwell and decision * book of medivh * Don't plague lore character * Better non-plaguing * add loc for invasion of QT * Change title change to conquest * localization for scourge army QT invasion * add some goals for future work on invasion of QT * add another requirement to QT subject chance * ALWAYS end the correct war * add resurrection (kinda broken) [SCQT] * change SCQT KT resurrect to use set_house for dyn * Fix the res * Add parents back * Sets dummy parents for purged characters * Fix errors * Transfer children of resurrected characters * Fix Kel'Thuzad trigger and appearance * Remove impotent trait from undead * Tiny simplification * Another small fix * fix SCQT edge cases * no more removing arthas as regent! * fix scqt.1001 * book works for non dlc holders * purple book is nicer (wish we had orange) * sylvanas loc * decision loc * event chain loc * Remove the second Kel'thuzad * equip_artifact_to_owner_replace loc * Generalize usurp_lordaeron_effect and give it loc * ranger general now dies with correct grammar * i made second dot * Update wc_scourge_quelthalas_events_l_english.yml * turn_realm_undead_effect effect loc * More bullet points * Fixed event option loc * Banshee/Spectre custom loc * Fix Quel'thalas borders after war * Give converted elves event army and fix small errors * Give Quel'thalas to an undead Elf * missed some gendered localisation * Add frostmourne to triggers * Remove special building from visible triggers * loc update * weight modifiers * Fix awkward sunwell building trigger loc * Frostmourne trigger loc * Darkfallen icon * Fix remaining errors --------- Co-authored-by: Raged50 <[email protected]> Co-authored-by: Edmund <[email protected]>
* Orc armor * Male blendshapes Male blendshapes for orc armor * Some fixes * work work Adjusted male helmet Added female helmet Adjusted male blendshapes * Orc armor * Orc armor * Female Blendshapes * Blendshape more like lameshape * I hate blendshapes and titts * First test for textures * CoA on orc armor * Final (?) male armor and textures Rigging and texture of the male armor are finish for now * Female model * drakkari dont wear orc clothing * Blendshape crash game * No more crashes No idea why * Fixed ass * Helmet coa and some fixes * breast bandage * bandage added to clothing * No more orc tits * Less helmets Theres a 60% the character use a helmet * Randomness working properly * No major orc wears helmet * Consistent code --------- Co-authored-by: Raged50 <[email protected]>
not workon on professions at the moment, but this commit will tell me what needs to be worked on when i pick it up again
|
will work on this later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog:
dont look at this i will be right back
Developer changelog:
Tests:
wcfiles inDocuments\Paradox Interactive\Crusader Kings III\logs\error.logexceptportrait_decals.cpp:101How to test: