Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made Naga Government Feudal instead of Eldritch #1286

Merged

Conversation

Myphicbowser
Copy link
Contributor

@Myphicbowser Myphicbowser commented Dec 18, 2023

Changelog:

  • Removed the Void Being trait from all Naga, as suggested by Raged in my suggestion post.

Tests:

  • There are no errors in wc files in Documents\Paradox Interactive\Crusader Kings III\logs\error.log except portrait_decals.cpp:101
  • The mod takes less than 5.5 GB in the Task Manager (Windows)

Removed Void Being trait from all Naga Historical Characters, Changed all Tribal Naga Holdings into Feudal
Turns some Feudal Holdings back into Tribal Holdings, sorry Raged
@Myphicbowser
Copy link
Contributor Author

I would like to have this either be discussed or deleted, I thought the idea was fine enough as the Religion Update will add their new religion and then we can add the Void Being trait to Azshara and have her rule Feudal Governments as an Eldritch. But I do not like PRs just sitting that change simple things and have been discussed.

Copy link
Contributor

@Raged50 Raged50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, error log clean

@Myphicbowser Myphicbowser merged commit c051096 into Warcraft-GoA-Development-Team:master Jan 5, 2024
1 check failed
@Myphicbowser Myphicbowser deleted the no-void-naga branch January 5, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants