Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable clan for preferred heritages #1285

Merged
merged 3 commits into from
Dec 20, 2023
Merged

enable clan for preferred heritages #1285

merged 3 commits into from
Dec 20, 2023

Conversation

edmund-h
Copy link
Contributor

@edmund-h edmund-h commented Dec 18, 2023 •
edited
Loading

Changelog:

  • Centaurs, Quillboars, Orcs, Tauren, and Gorians should now be able to form clans
Screenshot 2023-12-20 at 1 09 18 PM

Developer changelog:

  • added an if statement to fp3_decisions.txt with the preferred heritages listed in the updated PR

Tests:

  • There are no errors in wc files in Documents\Paradox Interactive\Crusader Kings III\logs\error.log except portrait_decals.cpp:101
  • The mod takes less than 5.5 GB in the Task Manager (Windows)

How to test:

@edmund-h edmund-h marked this pull request as ready for review December 20, 2023 18:13
ElMariuso
ElMariuso reviewed Dec 20, 2023
View reviewed changes
common/scripted_triggers/wc_government_triggers.txt
@@ -79,6 +79,9 @@ can_keep_clan_government_trigger = {
OR = {
culture = { has_cultural_pillar = heritage_orcish }
culture = { has_cultural_pillar = heritage_tauren }
culture = { has_cultural_pillar = heritage_gorian }
culture = { has_cultural_pillar = heritage_agamagganic }
culture = { has_cultural_pillar = heritage_zaetaric }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, you should put theses heritage in the governments files too for auto-generated content

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if u mean preferred_heritage in the clan govs file,
it's in there already in grek's branch, this is just adding them to the trigger

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok so

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you mean a different file O__o

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, if it's on greko branch, it's ok.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Grekopithikos please merge when ready : ]

@Grekopithikos Grekopithikos merged commit fe5e15a into tweaks-and-hotfixes Dec 20, 2023
1 check failed
@Grekopithikos Grekopithikos deleted the enable-clan-for-preferred-heritage branch December 20, 2023 18:33
@Gaben1025 Gaben1025 added this to the 0.5 Release Alpha milestone Dec 23, 2023
@edmund-h edmund-h linked an issue Jan 6, 2024 that may be closed by this pull request
Clan Governments for more Cultures #1275
Closed
@edmund-h edmund-h mentioned this pull request Jan 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ElMariuso ElMariuso ElMariuso left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.4.1 Release Alpha
Development

Successfully merging this pull request may close these issues.

Clan Governments for more Cultures
4 participants
@edmund-h @ElMariuso @Grekopithikos @Gaben1025