Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweaks and hotfixes #1279

Merged
merged 32 commits into from
Dec 22, 2023
Merged

Tweaks and hotfixes #1279

merged 32 commits into from
Dec 22, 2023

Conversation

Grekopithikos
Copy link
Contributor

@Grekopithikos Grekopithikos commented Dec 16, 2023 •
edited
Loading

Changelog:

  • Used Legacy of Persia traditions on cultures deemed fitting
  • Readjusted the modifiers of some buildings, also Boralus has the Boralus Harbor
  • Fixed the Nethergarde being potentially tribal by giving Nether Hill a castle holding when it becomes Dalaranian
  • Azuregos is no longer member of the Azurewing dynasty despite the name similarity
  • The Gloaming Reef is now murloc cultured as intended
  • Upgraded the education traits of some titanforged and dragon aspect characters
  • Added traits and renamed some dwarves and trolls to make them more lore accurate
  • Turned King Mechagon and his son mechagnomes
  • Gave mechagnomes 10000 lifespan so as to not die quick without infusion traits
  • Made some mechagnome characters that populate Mimiron and Mechagon's court

Tests:

  • There are no errors in wc files in Documents\Paradox Interactive\Crusader Kings III\logs\error.log except portrait_decals.cpp:101
  • The mod takes less than 5.5 GB in the Task Manager (Windows)

How to test:

ElMariuso
ElMariuso reviewed Dec 16, 2023
View reviewed changes
common/culture/cultures/wc_aqir.txt Outdated Show resolved Hide resolved
common/culture/cultures/wc_draconic.txt Outdated Show resolved Hide resolved
history/characters/62000_dragon.txt Show resolved Hide resolved
edmund-h
edmund-h previously requested changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@edmund-h edmund-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add the gnomish language to Mechagon rulers please so they can get along with their courtiers : ]

@Grekopithikos
vilebranch
aea8945 
gave character safety to the plot armor modifier
@Grekopithikos Grekopithikos dismissed edmund-h’s stale review December 21, 2023 16:41

Mechagon already speaks gnomish

@Grekopithikos
frostmane characters
78f7fbc 
also some mechagnome stuff
edmund-h
edmund-h previously requested changes Dec 22, 2023
View reviewed changes
Copy link
Contributor

@edmund-h edmund-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some minor tidbits

history/characters/mechagnome.txt Outdated Show resolved Hide resolved
history/characters/mechagnome.txt Outdated Show resolved Hide resolved
history/cultures/naga.txt Show resolved Hide resolved
history/provinces/00_k_alterac.txt Show resolved Hide resolved
history/characters/mechagnome.txt Outdated Show resolved Hide resolved
history/characters/mechagnome.txt Outdated Show resolved Hide resolved
history/characters/mechagnome.txt Outdated Show resolved Hide resolved
history/provinces/00_k_black_morass.txt Show resolved Hide resolved
localization/replace/english/dlc/fp3/wc_dlc_fp3_culture_l_english.yml Show resolved Hide resolved
common/culture/cultures/wc_aqir.txt Show resolved Hide resolved
sumankun
sumankun requested changes Dec 22, 2023
View reviewed changes
common/buildings/wc_special_buildings.txt Outdated Show resolved Hide resolved
common/buildings/wc_special_buildings.txt Outdated Show resolved Hide resolved
localization/english/bookmark/bookmark_605_l_english.yml Outdated Show resolved Hide resolved
sumankun
sumankun approved these changes Dec 22, 2023
View reviewed changes
Copy link
Contributor

@sumankun sumankun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Grekopithikos Grekopithikos merged commit 42b07ea into master Dec 22, 2023
1 check failed
@Grekopithikos Grekopithikos deleted the tweaks-and-hotfixes branch December 22, 2023 20:37
@Gaben1025 Gaben1025 added this to the 0.5 Release Alpha milestone Dec 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ElMariuso ElMariuso ElMariuso left review comments

@edmund-h edmund-h edmund-h left review comments

@sumankun sumankun sumankun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.4.1 Release Alpha
Development

Successfully merging this pull request may close these issues.
5 participants
@Grekopithikos @edmund-h @ElMariuso @sumankun @Gaben1025