Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New buildings #1254

Merged
merged 61 commits into from
Dec 5, 2023
Merged

New buildings #1254

merged 61 commits into from
Dec 5, 2023

Conversation

Grekopithikos
Copy link
Contributor

@Grekopithikos Grekopithikos commented Nov 27, 2023 •
edited
Loading

Changelog:

  • Added loads of mines throughout Azeroth
  • Added religious buildings like Northshire Abbey and Shado-pan Monastery
  • Added universities like Gearshaft University and Scholomance
  • Greymane Wall

Tests:

  • There are no errors in wc files in Documents\Paradox Interactive\Crusader Kings III\logs\error.log except portrait_decals.cpp:101
  • The mod takes less than 5.5 GB in the Task Manager (Windows)

How to test:

@Grekopithikos
Deadmines
3c9a8f8
@Grekopithikos
Merge branch 'master' into new-buildings
905aae3
@Grekopithikos
Mines
59c8591
@Grekopithikos
Mines placed
eb366a9
@Grekopithikos
Obelisks
e79ade7
@Grekopithikos
Merge branch 'master' into new-buildings
b39a1d5
@Grekopithikos
Scarlet Monastery
7b882a4
@Grekopithikos
Monasteries
55c20f8
@Grekopithikos
Mine triggers
ded2adc
@Grekopithikos
Merge branch 'master' into new-buildings
d7fedb7
@Grekopithikos
Northshire Abbey
609c07a
@Grekopithikos
Merge branch 'master' into new-buildings
3c47c4c
@Grekopithikos
Update 00_k_gilneas.txt
618462b
@Grekopithikos
Greymane Wall
bf4e157
@Grekopithikos
Merge branch 'master' into new-buildings
d231da0
@Grekopithikos
religious studies
d2eec79
@Grekopithikos
touru
cc4f84e
@Grekopithikos
Update wc_special_buildings.txt
1317f43
@Grekopithikos
loc fix
d35ef1b
@Grekopithikos
icons
24d85dd
@Grekopithikos
Update 00_k_broken_shores.txt
5001d3b
@Grekopithikos
Revert "Update 00_k_broken_shores.txt"
96c7b97 
This reverts commit 5001d3b.
@Grekopithikos
fixes
25b2e61
@Grekopithikos
Merge branch 'master' into new-buildings
1226712
@Grekopithikos
Update 320000_centaur.txt
f672b45
@Grekopithikos
fix
d4bccd2
@Grekopithikos
Merge branch 'master' into new-buildings
94f31e6
@Grekopithikos
Update wc_special_mines.txt
6929032
@Grekopithikos
Merge branch 'master' into new-buildings
64f75f0
@Grekopithikos
trees
644edf7
@arithon arithon added localisation 📄 This issue or pull request supposes localization changes lore 📚 Comes from lore history 👑 Involves changing history labels Dec 1, 2023
@sumankun sumankun added this to the 0.4 Release Alpha milestone Dec 1, 2023
arithon
arithon previously requested changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@arithon arithon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions, some fixes, some reminders to fill empty descriptions.

localization/english/wc_buildings_l_english.yml Outdated Show resolved Hide resolved
localization/english/wc_buildings_l_english.yml Outdated Show resolved Hide resolved
localization/english/wc_buildings_l_english.yml Outdated Show resolved Hide resolved
localization/english/wc_buildings_l_english.yml Show resolved Hide resolved
localization/english/wc_buildings_l_english.yml Outdated Show resolved Hide resolved
localization/english/wc_buildings_l_english.yml Show resolved Hide resolved
localization/english/wc_buildings_l_english.yml Outdated Show resolved Hide resolved
localization/english/wc_buildings_l_english.yml Outdated Show resolved Hide resolved
localization/english/wc_buildings_l_english.yml Outdated Show resolved Hide resolved
localization/english/wc_buildings_l_english.yml Outdated Show resolved Hide resolved
Grekopithikos and others added 18 commits December 1, 2023 22:07
@Grekopithikos
Merge branch 'master' into new-buildings
b84c318
@Grekopithikos
Scarlet Monastery and Greymane wall moved
a1f3dd1
@Grekopithikos @arithon
Update localization/english/wc_buildings_l_english.yml
a0da42a 
Co-authored-by: arithon <[email protected]>
@Grekopithikos
karazhan's not popular
c82017c
@Grekopithikos
Update wc_buildings_l_english.yml
4157b38
@Grekopithikos
Merge branch 'master' into new-buildings
6c4b89e
@Grekopithikos
Bravo Company and Torq Ironblast
c65d756
@Grekopithikos
narthalas icon
d754680
@Grekopithikos
more icons
b2d6367
@Rekutur
Building Icons for Broken Isles
a86cdc6 
Added building icons for broken isles.
@Grekopithikos
Revert "more icons"
18a4ca1 
This reverts commit b2d6367.
@Grekopithikos
Merge remote-tracking branch 'origin/Building-Icons-for-Broken-Isles'…
cb44f1b 
… into new-buildings
@Grekopithikos
structures
bc175ad
@Grekopithikos
Update 1_azerothian.txt
f3d4e63
@Grekopithikos
Update wc_character_names_l_english.yml
98e7761
@Grekopithikos
ages adjusted
2781e2a
@Grekopithikos
Update wc_buildings_l_english.yml
f7bbae1
@Grekopithikos
Update 00_wc_landed_titles.txt
91644b8
ElMariuso
ElMariuso suggested changes Dec 5, 2023
View reviewed changes
history/provinces/00_k_lordaeron.txt Outdated Show resolved Hide resolved
ElMariuso
ElMariuso approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@ElMariuso ElMariuso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Grekopithikos Grekopithikos dismissed arithon’s stale review December 5, 2023 23:37

all requests are resolved

@Grekopithikos Grekopithikos merged commit 1424349 into master Dec 5, 2023
1 check failed
@Grekopithikos Grekopithikos deleted the new-buildings branch December 5, 2023 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sumankun sumankun sumankun left review comments

@ElMariuso ElMariuso ElMariuso approved these changes

@arithon arithon arithon left review comments

Assignees

@Grekopithikos Grekopithikos

Labels
history 👑 Involves changing history localisation 📄 This issue or pull request supposes localization changes lore 📚 Comes from lore
Projects
None yet
Milestone
0.4 Release Alpha
Development

Successfully merging this pull request may close these issues.
5 participants
@Grekopithikos @ElMariuso @arithon @sumankun @Rekutur