Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Harpy models #1253

Merged
merged 20 commits into from
Nov 27, 2023
Merged

Harpy models #1253

merged 20 commits into from
Nov 27, 2023

Conversation

sumankun
Copy link
Contributor

@sumankun sumankun commented Nov 26, 2023 •
edited
Loading

Changelog:

  • Removed static harpies
  • Added real models

Tests:

  • There are no errors in wc files in Documents\Paradox Interactive\Crusader Kings III\logs\error.log

@sumankun sumankun marked this pull request as ready for review November 26, 2023 21:44
@sumankun sumankun requested a review from a team November 26, 2023 21:45
ElMariuso
ElMariuso approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@ElMariuso ElMariuso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any problem with portraits, no clipping or anything.
And nothing in error.logs either.

The harpies looks good, they look vicious. LGTM

@sumankun sumankun merged commit fc5d38f into master Nov 27, 2023
1 check failed
@sumankun sumankun deleted the harpy-models branch November 27, 2023 22:10
@Gaben1025 Gaben1025 added this to the 0.4 Release Alpha milestone Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ElMariuso ElMariuso ElMariuso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.4 Release Alpha
Development

Successfully merging this pull request may close these issues.
3 participants
@sumankun @ElMariuso @Gaben1025