-
-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Terrain brokenisles 1.10 #1246
Merged
Merged
Terrain brokenisles 1.10 #1246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also adjusted Drak'thul's personality to be more accurate
…t-GoA-Development-Team/Warcraft-Guardians-of-Azeroth-2 into terrain-brokenisles-1.10
arithon
added
lore 📚
Comes from lore
localisation 📄
This issue or pull request supposes localization changes
2D graphics 🖌️
Involves tweaking/adding 2D arts
character designing 😶
Involves tweaking DNAs or either ethnicities or charactes
cartography 🌐
Involves working in the map editor
labels
Nov 25, 2023
…t-GoA-Development-Team/Warcraft-Guardians-of-Azeroth-2 into terrain-brokenisles-1.10
sumankun
approved these changes
Nov 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
2D graphics 🖌️
Involves tweaking/adding 2D arts
cartography 🌐
Involves working in the map editor
character designing 😶
Involves tweaking DNAs or either ethnicities or charactes
localisation 📄
This issue or pull request supposes localization changes
lore 📚
Comes from lore
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog:
Added the following playable races:
Nightborne
Fal'dorei
Sea Giants
Gilgoblins
Drogbar
Reworked Broken Isles terrain appearance to make it more interesting and less plain
De jure High Kingdom of Lordaeron given terrain appearance rework
Custom characters added for lore appropriate provinces
Satyr given non-static ethnicity
Added the following unique buildings:
Miscellaneous History error fixes:
Can't remember the rest...
Todo:
Tests:
[14:47:25][pdx_localize.cpp:279]: Duplicate localization key. Key 'b_larne' is defined in both 'localization/english/00_mapfiller_titles_l_english.yml' and 'localization/english/titles_l_english.yml'.
[14:47:25][pdx_localize.cpp:279]: Duplicate localization key. Key 'b_ronda' is defined in both 'localization/english/00_mapfiller_titles_l_english.yml' and 'localization/english/titles_l_english.yml'.
[14:47:25][pdx_localize.cpp:279]: Duplicate localization key. Key 'b_ramu' is defined in both 'localization/english/00_mapfiller_titles_l_english.yml' and 'localization/english/titles_l_english.yml'.