Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terrain brokenisles 1.10 #1246

Merged
merged 160 commits into from
Nov 26, 2023
Merged

Terrain brokenisles 1.10 #1246

merged 160 commits into from
Nov 26, 2023

Conversation

Raged50
Copy link
Contributor

@Raged50 Raged50 commented Nov 22, 2023

Changelog:

  • Added 105 new counties
  • Added the following kingdoms:
  • Suramar, Azsuna, Highmountain, Val'sharah, Stormheim, Broken Shores
  • Added the Empire of the Broken Isles

Added the following playable races:

  • Nightborne

  • Fal'dorei

  • Sea Giants

  • Gilgoblins

  • Drogbar

  • Reworked Broken Isles terrain appearance to make it more interesting and less plain

  • De jure High Kingdom of Lordaeron given terrain appearance rework

  • Custom characters added for lore appropriate provinces

  • Satyr given non-static ethnicity

Added the following unique buildings:

  • Nar'thalas academy
  • Crypt Tunnels of Falanaar
  • Cathedral of Eternal Night

Miscellaneous History error fixes:

  • Added title history and custom characters in Feralas
  • Made several fixes to title history in Wintergrasp area
  • Moved Winterwood tribe to Yiwo and created title history suggesting a recent hostile takeover

Can't remember the rest...

Todo:

  • Nightwell
  • World Tree
  • Icons for special buildings

Tests:

  • Known errors: [14:47:25][pdx_localize.cpp:279]: Duplicate localization key. Key 'b_carrion' is defined in both 'localization/english/00_mapfiller_titles_l_english.yml' and 'localization/english/titles_l_english.yml'.
    [14:47:25][pdx_localize.cpp:279]: Duplicate localization key. Key 'b_larne' is defined in both 'localization/english/00_mapfiller_titles_l_english.yml' and 'localization/english/titles_l_english.yml'.
    [14:47:25][pdx_localize.cpp:279]: Duplicate localization key. Key 'b_ronda' is defined in both 'localization/english/00_mapfiller_titles_l_english.yml' and 'localization/english/titles_l_english.yml'.
    [14:47:25][pdx_localize.cpp:279]: Duplicate localization key. Key 'b_ramu' is defined in both 'localization/english/00_mapfiller_titles_l_english.yml' and 'localization/english/titles_l_english.yml'.

@arithon arithon requested a review from a team November 25, 2023 19:48
@arithon arithon added lore 📚 Comes from lore localisation 📄 This issue or pull request supposes localization changes 2D graphics 🖌️ Involves tweaking/adding 2D arts character designing 😶 Involves tweaking DNAs or either ethnicities or charactes cartography 🌐 Involves working in the map editor labels Nov 25, 2023
Copy link
Contributor

@sumankun sumankun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Raged50 Raged50 merged commit aa6fa84 into master Nov 26, 2023
1 check failed
@Raged50 Raged50 deleted the terrain-brokenisles-1.10 branch November 26, 2023 18:01
@Gaben1025 Gaben1025 added this to the 0.4 Release Alpha milestone Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2D graphics 🖌️ Involves tweaking/adding 2D arts cartography 🌐 Involves working in the map editor character designing 😶 Involves tweaking DNAs or either ethnicities or charactes localisation 📄 This issue or pull request supposes localization changes lore 📚 Comes from lore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants