Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Infirm issue 1241 fix #1244

Merged
merged 11 commits into from
Nov 21, 2023
Merged

Infirm issue 1241 fix #1244

merged 11 commits into from
Nov 21, 2023

Conversation

edmund-h
Copy link
Contributor

@edmund-h edmund-h commented Nov 20, 2023 •
edited
Loading

Changelog:

  • Prevent high-longevity characters (Dragons, Elves, Undead, etc) from getting the Infirm trait
  • As a result of changes, Infirm is now relatively rare.

Developer changelog:

  • Changed how age_ranked_health_vulnerability_threshold_trigger in 20_health_triggers.txt works and made it the source of truth for infirm checks

Tests:

  • There are no errors in wc files in Documents\Paradox Interactive\Crusader Kings III\logs\error.log except portrait_decals.cpp:101
  • The mod takes less than 5.5 GB in the Task Manager (Windows)

How to test:

I've been testing by running observer mode and searching "infirm" in the character search tool once a year. Usually about 40 characters show up with Infirm. Please feel free to try to test in your own way though!

@edmund-h edmund-h linked an issue Nov 20, 2023 that may be closed by this pull request
Infirm Trait on Long Lived Races #1241
Closed
sumankun
sumankun requested changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@sumankun sumankun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didnt check logical thing, only technical.

common/scripted_triggers/20_health_triggers.txt Outdated Show resolved Hide resolved
common/scripted_triggers/20_health_triggers.txt Outdated Show resolved Hide resolved
events/health_events.txt Outdated Show resolved Hide resolved
sumankun
sumankun approved these changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@sumankun sumankun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@edmund-h edmund-h merged commit 8d7308d into master Nov 21, 2023
1 check failed
@edmund-h edmund-h deleted the infirm-issue-1241-fix branch November 21, 2023 21:30
@Gaben1025 Gaben1025 added this to the 0.4 Release Alpha milestone Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sumankun sumankun sumankun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.4 Release Alpha
Development

Successfully merging this pull request may close these issues.

Infirm Trait on Long Lived Races
3 participants
@edmund-h @sumankun @Gaben1025