-
-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Union rework #1236
Merged
Merged
Union rework #1236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sumankun
requested review from
a team,
ElMariuso,
Grekopithikos and
Gaben1025
November 2, 2023 04:19
ElMariuso
approved these changes
Nov 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as I said in PM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog:
-universal code to easier add new unions. Each union is one story cycle
-You can call your union members in offensive wars only if you are the leader of the union. High (de)centralization can change it
-Marriage penalty modifier for acception doesnt take union allies into account
-Forsaken can easier join horde if they took any kingdom (Lordaeron for Sylvanas). And people dont leave the union if Sylvanas(or other undead) became a leader of the Horde
added 4 new unions
universal decisions for create/join/leave union
new union game rule. If you enable it, all states inside one faction will have same color on political map. Every union has its own color
union elections. Every candidate has a score. The score is a chance to become the next leader. Your chance = (your score/total score of all candidates). Score depends on various conditions(tier level, stats, prestige level etc). You can invest prestige/gold to increase chances
centralization-decentralization system, which decides what bonuses union members/union leader get from character modifier. It also influences who you can call into offensive war from union and determines penalty/bonus for score of primary heir of the current union leader
Tests:
wc
files inDocuments\Paradox Interactive\Crusader Kings III\logs\error.log