Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Union rework #1236

Merged
merged 31 commits into from
Nov 8, 2023
Merged

Union rework #1236

merged 31 commits into from
Nov 8, 2023

Conversation

sumankun
Copy link
Contributor

@sumankun sumankun commented Oct 31, 2023

Changelog:

-universal code to easier add new unions. Each union is one story cycle
-You can call your union members in offensive wars only if you are the leader of the union. High (de)centralization can change it
-Marriage penalty modifier for acception doesnt take union allies into account
-Forsaken can easier join horde if they took any kingdom (Lordaeron for Sylvanas). And people dont leave the union if Sylvanas(or other undead) became a leader of the Horde

added 4 new unions

image

universal decisions for create/join/leave union

image

new union game rule. If you enable it, all states inside one faction will have same color on political map. Every union has its own color

image

union elections. Every candidate has a score. The score is a chance to become the next leader. Your chance = (your score/total score of all candidates). Score depends on various conditions(tier level, stats, prestige level etc). You can invest prestige/gold to increase chances

image

centralization-decentralization system, which decides what bonuses union members/union leader get from character modifier. It also influences who you can call into offensive war from union and determines penalty/bonus for score of primary heir of the current union leader

image

Tests:

  • There are no errors in wc files in Documents\Paradox Interactive\Crusader Kings III\logs\error.log

@sumankun sumankun marked this pull request as ready for review November 2, 2023 04:19
@sumankun sumankun requested review from a team, ElMariuso, Grekopithikos and Gaben1025 November 2, 2023 04:19
@sumankun sumankun added this to the 0.4 Release Alpha milestone Nov 2, 2023
Copy link
Contributor

@ElMariuso ElMariuso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as I said in PM

@sumankun sumankun merged commit a737e54 into master Nov 8, 2023
1 check failed
@sumankun sumankun deleted the union-rework branch November 8, 2023 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants