Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Goblin Loan Mechanic #1228

Merged
merged 5 commits into from
Oct 3, 2023
Merged

Goblin Loan Mechanic #1228

merged 5 commits into from
Oct 3, 2023

Conversation

sumankun
Copy link
Contributor

@sumankun sumankun commented Oct 2, 2023

This is the Goblins Loans system. As far as i checked there are no errors in error.log

Changelog:

  • Decision for borrowing/paying back loan.
  • Fortunistic faith has a head of faith, which funtions as bank and called Fortunistic Reserve System. All loans are taken and go back to this title. (discussed with Mariuso). Rulers of this title has titlename Banker.
  • Due to vanilla character interaction ask gold from head of faith, this bank can help for all Fortunistic rulers.
  • You return the debt paying 4 times (1/4)+25% on top of it. It asks to return 1/4 of debt every 5 years, the first pay out can take a little longer.
  • FRS holder has modifier +10 gold per month
Daelin took debt, first pay back

image

There are three options

image
image
image

Son successfully inherited the loan

image

Tests:

  • There are no errors in wc files in Documents\Paradox Interactive\Crusader Kings III\logs\error.log

How to test:

  • There is minor decision to take loan from goblins
  • Periodically (usually 5 years) They ask to return 1/4 debt +25% on top. Or you can pay back though decision
  • If you die, your heir inherit the loan

@Grekopithikos
Copy link
Contributor

You made a new character for the title?
Wouldn't it make more sense for the Steamwheedle Trade Prince to be the head of faith?

@ElMariuso
Copy link
Contributor

You made a new character for the title? Wouldn't it make more sense for the Steamwheedle Trade Prince to be the head of faith?

No?

@Grekopithikos
Copy link
Contributor

hmm ok nevermind then

@sumankun sumankun marked this pull request as ready for review October 3, 2023 10:15
@sumankun sumankun requested review from Gaben1025, ElMariuso, a team and arithon October 3, 2023 10:15
Copy link
Contributor

@Gaben1025 Gaben1025 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work, no errors in log, this is exactly what I had in mind LGTM!

@sumankun sumankun force-pushed the goblin-loan-mechanic branch from 428fd95 to d8e58ee Compare October 3, 2023 15:05
Copy link
Contributor

@arithon arithon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just minor things, good in general.

localization/english/wc_decisions_l_english.yml Outdated Show resolved Hide resolved
localization/english/wc_decisions_l_english.yml Outdated Show resolved Hide resolved
@arithon arithon self-requested a review October 3, 2023 20:42
Copy link
Contributor

@arithon arithon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sumankun sumankun merged commit 96d7b3a into master Oct 3, 2023
1 check failed
@sumankun sumankun deleted the goblin-loan-mechanic branch October 3, 2023 20:43
@Gaben1025 Gaben1025 added this to the 0.4 Release Alpha milestone Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants