-
-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Goblin Loan Mechanic #1228
Goblin Loan Mechanic #1228
Conversation
You made a new character for the title? |
No? |
hmm ok nevermind then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work, no errors in log, this is exactly what I had in mind LGTM!
428fd95
to
d8e58ee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just minor things, good in general.
Co-authored-by: arithon <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This is the Goblins Loans system. As far as i checked there are no errors in
error.log
Changelog:
loan
.Fortunistic
faith has a head of faith, which funtions as bank and calledFortunistic Reserve System
. All loans are taken and go back to this title. (discussed with Mariuso). Rulers of this title has titlenameBanker
.ask gold from head of faith
, this bank can help for all Fortunistic rulers.FRS holder
hasmodifier
+10 gold per monthDaelin took debt, first pay back
There are three options
Son successfully inherited the loan
Tests:
wc
files inDocuments\Paradox Interactive\Crusader Kings III\logs\error.log
How to test: