Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Goblin Loan Decision #1040

Closed
wants to merge 15 commits into from
Closed

Goblin Loan Decision #1040

wants to merge 15 commits into from

Conversation

PIKSKING
Copy link

This is the Goblins Loans system,Check for bugs or missing properties,also open to any suggestion

Changelog:

  • remade the whole thing.

Developer changelog:

  • remade it

Tests:

  • There are no errors in wc files in Documents\Paradox Interactive\Crusader Kings III\logs\error.log except portrait_decals.cpp:101
  • The mod takes less than 5.5 GB in the Task Manager (Windows)

How to test:

Play as Anyone (not evil relegion or tribal) and see if you can take a loan,then switch to a tribal/evil relegion character and see if the decision is still there.

This is the Goblins Loans system,Check for bugs or missing properties,also open to any suggestion
@PIKSKING PIKSKING requested a review from Gaben1025 March 16, 2023 15:37
@PIKSKING PIKSKING self-assigned this Mar 16, 2023
@PIKSKING PIKSKING added new feature ⭐ Involves adding new feature that affects game vanilla modification 🍦 Involves vanilla modifications labels Mar 16, 2023
@PIKSKING PIKSKING changed the title Add files via upload Goblin Load Decision Mar 16, 2023
@PIKSKING PIKSKING changed the title Goblin Load Decision Goblin Loan Decision Mar 16, 2023
@PIKSKING PIKSKING requested review from a team March 17, 2023 07:11
MoonyMeanie and others added 3 commits March 20, 2023 01:57
gb_1 is meant to represent the Steamwheedle Cartel, and gb_2 is meant to represent the Bilgewater-
…ie-patch-1

Update goblin_money_l_english.yml

highest_held_title_tier > tier_barony
NOT = {
highest_held_title_tier > tier_barony
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

you are causing a contradiction, this is why it does not show up at all.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done,test again before release if its possible

Copy link
Contributor

@TheGroxEmpire TheGroxEmpire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The decision seems to work fine even after switching characters. However, the image proportion on this decision is a bit off. The description also doesn't appear.

image
image

@PIKSKING
Copy link
Author

the image is good for now,till i swtich to another image but the other one is a localization problem

@IronyOwl
Copy link
Contributor

Seems a bit rough.

First time the game crashed entirely. Not sure if it was related to this or something else, but it's something to consider if it happens again.

500 gold for 100 prestige feels rather powerful. Granted it's a loan, and 75 in interest is fairly steep, but I wonder if it's strong enough to be a standard strategy.

After a while an event fired giving me a fairly hefty negative trait for not paying back the goblins, but there wasn't enough text to explain just what was happening. Did I take too long to pay it back and they got mad?

Once that was done, I was able to take out another loan, and then use that loan to pay off the first loan, resulting in no loans. Or at least, there was no button to repay the second loan, so I assume it got wiped out along with the first.

There's hardly any localization, flavor text, or an icon for the negative trait.

@PIKSKING
Copy link
Author

Oh wait,i know the localization problem,its because a wrong tag for the descs
but i couldnt try it in good condition with the mod.

@PIKSKING PIKSKING requested a review from a team September 13, 2023 05:48
@PIKSKING
Copy link
Author

I did a remake from the previous works and mods, I am sure this time it should work.

Copy link
Contributor

@Gaben1025 Gaben1025 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

  • 2 events

image

  • No image
  • You get a bonus from lending even though the description says you are late to pay back the loan
  • Goblins do not get payback loan casus beli on loanee

@sumankun sumankun closed this Oct 2, 2023
@sumankun sumankun deleted the Goblinloan-patch-1 branch October 2, 2023 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature ⭐ Involves adding new feature that affects game vanilla modification 🍦 Involves vanilla modifications
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants