Fixed Majority Of Error Log

Two errors remain that I am not sure how to fix: - hidden, which I use to hide the effects of an option at line 4958 - Artifact visual type since I only have a 2D icon and no model for the totem artifact
Warcraft-GoA-Development-Team · Nov 18, 2023 · 1bf94c1 · 1bf94c1
1 parent 7bce900
commit 1bf94c1
Show file tree

Hide file tree

Showing 2 changed files with 33 additions and 49 deletions.
diff --git a/common/decisions/wc_cen_kal_decisions.txt b/common/decisions/wc_cen_kal_decisions.txt
@@ -66,6 +66,8 @@ change_agamaggan_blessing = {
 
 	cooldown = { years = 1 }
 
+	trigger = { has_variable = blood_shard_count }
+
 	is_shown = {
 		is_landed = yes
 		faith = faith:agamaggan_worship

diff --git a/events/wc_events/wc_central_kalimdor_events.txt b/events/wc_events/wc_central_kalimdor_events.txt
@@ -4902,7 +4902,7 @@ cen_kal.1077 = {
 
 	immediate = {
 		create_character = {
-			location = title:b_redrock
+			location = title:c_redrock.title_province
 			culture = culture:tauren
 			faith = faith:earth_mother_worship
 			dynasty = generate
@@ -5290,14 +5290,12 @@ cen_kal.1082 = {
 				creator = root
 				type = hammer
 				visuals = totem
+				name = cen_kal.1082.totem_1.name
+				description = cen_kal.1082.totem_1.desc
 				modifier = totem_1
 				rarity = masterwork
 				save_scope_as = newly_created_artifact
 			}
-			scope:newly_created_artifact = {
-				set_artifact_name = cen_kal.1082.totem_1.name
-				set_artifact_description = cen_kal.1082.totem_1.desc
-			}
 		}
 	}
 	option = {
@@ -5313,12 +5311,10 @@ cen_kal.1082 = {
 				visuals = totem
 				modifier = totem_2
 				rarity = masterwork
+				name = cen_kal.1082.totem_2.name
+				description = cen_kal.1082.totem_2.desc
 				save_scope_as = newly_created_artifact
 			}
-			scope:newly_created_artifact = {
-				set_artifact_name = cen_kal.1082.totem_2.name
-				set_artifact_description = cen_kal.1082.totem_2.desc
-			}
 		}
 	}
 	option = {
@@ -5334,12 +5330,10 @@ cen_kal.1082 = {
 				visuals = totem
 				modifier = totem_3
 				rarity = masterwork
+				name = cen_kal.1082.totem_3.name
+				description = cen_kal.1082.totem_3.desc
 				save_scope_as = newly_created_artifact
 			}
-			scope:newly_created_artifact = {
-				set_artifact_name = cen_kal.1082.totem_3.name
-				set_artifact_description = cen_kal.1082.totem_3.desc
-			}
 		}
 	}
 	option = {
@@ -5355,12 +5349,10 @@ cen_kal.1082 = {
 				visuals = totem
 				modifier = totem_4
 				rarity = masterwork
+				name = cen_kal.1082.totem_4.name
+				description = cen_kal.1082.totem_4.desc
 				save_scope_as = newly_created_artifact
 			}
-			scope:newly_created_artifact = {
-				set_artifact_name = cen_kal.1082.totem_4.name
-				set_artifact_description = cen_kal.1082.totem_4.desc
-			}
 		}
 	}
 	option = {
@@ -5376,12 +5368,10 @@ cen_kal.1082 = {
 				visuals = totem
 				modifier = totem_5
 				rarity = masterwork
+				name = cen_kal.1082.totem_5.name
+				description = cen_kal.1082.totem_5.desc
 				save_scope_as = newly_created_artifact
 			}
-			scope:newly_created_artifact = {
-				set_artifact_name = cen_kal.1082.totem_5.name
-				set_artifact_description = cen_kal.1082.totem_5.desc
-			}
 		}
 	}
 	option = {
@@ -5397,12 +5387,10 @@ cen_kal.1082 = {
 				visuals = totem
 				modifier = totem_6
 				rarity = masterwork
+				name = cen_kal.1082.totem_6.name
+				description = cen_kal.1082.totem_6.desc
 				save_scope_as = newly_created_artifact
 			}
-			scope:newly_created_artifact = {
-				set_artifact_name = cen_kal.1082.totem_6.name
-				set_artifact_description = cen_kal.1082.totem_6.desc
-			}
 		}
 	}
 }
@@ -5427,12 +5415,10 @@ cen_kal.1092 = {
 				visuals = totem
 				modifier = totem_1
 				rarity = masterwork
+				name = cen_kal.1082.totem_1.name
+				description = cen_kal.1082.totem_1.desc
 				save_scope_as = newly_created_artifact
 			}
-			scope:newly_created_artifact = {
-				set_artifact_name = cen_kal.1082.totem_1.name
-				set_artifact_description = cen_kal.1082.totem_1.desc
-			}
 		}
 	}
 	option = {
@@ -5448,12 +5434,10 @@ cen_kal.1092 = {
 				visuals = totem
 				modifier = totem_2
 				rarity = masterwork
+				name = cen_kal.1082.totem_2.name
+				description = cen_kal.1082.totem_2.desc
 				save_scope_as = newly_created_artifact
 			}
-			scope:newly_created_artifact = {
-				set_artifact_name = cen_kal.1082.totem_2.name
-				set_artifact_description = cen_kal.1082.totem_2.desc
-			}
 		}
 	}
 	option = {
@@ -5469,12 +5453,10 @@ cen_kal.1092 = {
 				visuals = totem
 				modifier = totem_3
 				rarity = masterwork
+				name = cen_kal.1082.totem_3.name
+				description = cen_kal.1082.totem_3.desc
 				save_scope_as = newly_created_artifact
 			}
-			scope:newly_created_artifact = {
-				set_artifact_name = cen_kal.1082.totem_3.name
-				set_artifact_description = cen_kal.1082.totem_3.desc
-			}
 		}
 	}
 	option = {
@@ -5490,12 +5472,10 @@ cen_kal.1092 = {
 				visuals = totem
 				modifier = totem_4
 				rarity = masterwork
+				name = cen_kal.1082.totem_4.name
+				description = cen_kal.1082.totem_4.desc
 				save_scope_as = newly_created_artifact
 			}
-			scope:newly_created_artifact = {
-				set_artifact_name = cen_kal.1082.totem_4.name
-				set_artifact_description = cen_kal.1082.totem_4.desc
-			}
 		}
 	}
 	option = {
@@ -5511,12 +5491,10 @@ cen_kal.1092 = {
 				visuals = totem
 				modifier = totem_5
 				rarity = masterwork
+				name = cen_kal.1082.totem_5.name
+				description = cen_kal.1082.totem_5.desc
 				save_scope_as = newly_created_artifact
 			}
-			scope:newly_created_artifact = {
-				set_artifact_name = cen_kal.1082.totem_5.name
-				set_artifact_description = cen_kal.1082.totem_5.desc
-			}
 		}
 	}
 	option = {
@@ -5532,12 +5510,10 @@ cen_kal.1092 = {
 				visuals = totem
 				modifier = totem_6
 				rarity = masterwork
+				name = cen_kal.1082.totem_6.name
+				description = cen_kal.1082.totem_6.desc
 				save_scope_as = newly_created_artifact
 			}
-			scope:newly_created_artifact = {
-				set_artifact_name = cen_kal.1082.totem_6.name
-				set_artifact_description = cen_kal.1082.totem_6.desc
-			}
 		}
 	}
 }
@@ -5601,6 +5577,7 @@ cen_kal.1085 = {
 	#Wait for now, add decision
 	option = {
 		name = cen_kal.1085.a
+		trigger = { has_variable = ebru }
 		scope:ebru = { set_employer = root }
 		set_variable = {
 			name = fanglords_spawn_rate
@@ -5889,31 +5866,36 @@ cen_kal.1088 = {
 			}
 			create_character = {
 				template = druid_fang
+				employer = scope:druid_leader_serpentis
 				gender = male
 				name = "Boahn"
 				after_creation = { set_employer = scope:druid_leader_serpentis }
 			}
 			create_character = {
 				template = druid_fang
+				employer = scope:druid_leader_serpentis
 				gender = female
 				name = "Anacondra"
 				after_creation = { set_employer = scope:druid_leader_serpentis }
 			}
 			create_character = {
 				template = druid_fang
+				employer = scope:druid_leader_serpentis
 				gender = male
 				name = "Cobrahn"
 				trait = giant
 				after_creation = { set_employer = scope:druid_leader_serpentis }
 			}
 			create_character = {
 				template = druid_fang
+				employer = scope:druid_leader_serpentis
 				gender = male
 				name = "Pythas"
 				after_creation = { set_employer = scope:druid_leader_serpentis }
 			}
 			create_character = {
 				template = druid_fang
+				employer = scope:druid_leader_serpentis
 				gender = male
 				name = "Mythen"
 				after_creation = { set_employer = scope:druid_leader_serpentis }