This repository has been archived by the owner on Sep 4, 2020. It is now read-only.
Use AST to pull a test's $Desired value #191
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
chriswahl
approved these changes
Oct 14, 2017
| @@ -210,31 +210,17 @@ function New-VesterConfig { | |||
| Default {$null} | |||
| } | |||
|
|
|||
| # TODO: Should probably offload this to a private function | |||
There was a problem hiding this comment.
Glad to see this happened. :)
There was a problem hiding this comment.
While I'm super happy with how this PR turned out, and how much freaking work I'll be doing with the AST moving forward...I think you found the easter egg I was most excited about. 👌
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New-VesterConfigneeds to ask each Vest what its config value should be named. To do this, I used RegEx. (I like RegEx, but this is true.)To fix #178, I employed my new best friend, PowerShell's AST. Private function
Get-VestConfigValuenow handles this work.New-VesterConfighas been updated with the changes, andSet-VesterConfigValuehas been updated to no longer expect the$Matchesvariable.(.md files will merge in with the other PR)