Feature/ss 5 compatibility updates #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jack-nzl
commented
Jan 17, 2025
jack-nzl
commented
- Silverstripe 5 and php8.3 compatibility upgrades
- Tidied up module code
- Removed some uselesss unit tests - unit tests are still broken, but there is enough space in my brain or schedule to deal with it
…ger required or just plain overkill
…ger required or just plain overkill
wilr
reviewed
Jan 17, 2025
| @@ -1,60 +1,67 @@ | |||
| <?php | |||
|
|
|||
| namespace Sunnysideup\DMS\Cms; | |||
| namespace YourNamespace\Extensions; | |||
There was a problem hiding this comment.
Should this namespace be something else? YourNamespace doesn't sound right
src/Model/DMSDocumentSet.php
Outdated
|
|
||
| private static $has_one = [ | ||
| private static $has_one = array( |
There was a problem hiding this comment.
This is the oppostie of what we should be doing. [ is prefered over array(
| /** | ||
| * Ensures that the DMS Document CMS Related and Versions fields are removed if user can't edit | ||
| */ | ||
| public function testDocumentHasNoCMSFieldsForManagingRelatedDocumentsIfCantEdit() |
There was a problem hiding this comment.
These tests are worth keeping as they're testing the permission model. We're verifying that the custom permissions work (which is likely an important feature)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.