Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mdk/add client tests #67

Draft
wants to merge 51 commits into
base: dev
Choose a base branch
from

Conversation

MichaelKetchel
Copy link
Contributor

Type of change

This is a draft PR built against my existing WiFi overhaul branch. Issue and cleanup to come, just want it to be visible.

Pick at least one.

  • Bug fix (non-breaking change that fixes something)
  • Documentation update (readme, changelog, man page, etc.)
  • New feature (non-breaking change adding functionality)
  • Breaking change (fix or feature changing existing functionality)
  • Code quality improvement (refactor, performance improvements)
  • Other (please specify):

Breaking change

Does this Pull Request introduce a breaking change?
No known breaks

Proposed change

Adds various tests and tools leveraging the new WLAN capabilities. These include, all scopable to any interface:

  • traceroute
  • dig
  • dhcp test with response time
  • ping
  • iperf2 client

Not wlan specific:

  • a reboot command in case things break bad and need a reset.

Testing

Please explain how you tested this change manually, and if applicable, what new tests you added.
No new automated tests (yet)
No affects on existing tests

Checklist

  • I have read the contribution guidelines and policies
  • I have targeted this PR against the correct git branch
  • I ran the test suite and verified it succeeded
  • I linked an approved GitHub issue to this PR (in the next section). No PR without a related GH issue. Conversations about your PR efforts in other channels such as electronic mail, social media, morse code, and WLAN Pi Slack do not count.
  • I have updated the changelog (if applicable)
  • I have added or updated the documentation (if applicable)

Related Issues/PRs

Pick at least one.

  • This PR fixes/closes issue #
  • This PR is related to issue #
  • This PR depends on/blocks PR #

Michael Ketchel and others added 30 commits October 25, 2024 15:32
* add error handling when removing iptables rule (WLAN-Pi#51)
# Conflicts:
#	wlanpi_core/services/network_service.py
#	wlanpi_core/utils/general.py
#	wlanpi_core/utils/network.py
and some other cleanups and fixes
return Response(content=ve.error_msg, status_code=ve.status_code)
except Exception as ex:
log.error(ex)
return Response(content=f"Internal Server Error: {ex}", status_code=500)

Check warning

Code scanning / CodeQL

Information exposure through an exception Medium

Stack trace information
flows to this location and may be exposed to an external user.
return Response(content=ve.error_msg, status_code=ve.status_code)
except Exception as ex:
log.error(ex, exc_info=ex)
return Response(content=f"Internal Server Error: {ex}", status_code=500)

Check warning

Code scanning / CodeQL

Information exposure through an exception Medium

Stack trace information
flows to this location and may be exposed to an external user.
return Response(content=ve.error_msg, status_code=ve.status_code)
except Exception as ex:
log.error(ex, exc_info=ex)
return Response(content=f"Internal Server Error: {ex}", status_code=500)

Check warning

Code scanning / CodeQL

Information exposure through an exception Medium

Stack trace information
flows to this location and may be exposed to an external user.
return Response(content=ve.error_msg, status_code=ve.status_code)
except Exception as ex:
log.error(ex, exc_info=ex)
return Response(content=f"Internal Server Error: {ex}", status_code=500)

Check warning

Code scanning / CodeQL

Information exposure through an exception Medium

Stack trace information
flows to this location and may be exposed to an external user.
return Response(content=ve.error_msg, status_code=ve.status_code)
except Exception as ex:
log.error(ex, exc_info=ex)
return Response(content=f"Internal Server Error: {ex}", status_code=500)

Check warning

Code scanning / CodeQL

Information exposure through an exception Medium

Stack trace information
flows to this location and may be exposed to an external user.
return Response(content=ve.error_msg, status_code=ve.status_code)
except Exception as ex:
log.error(ex, exc_info=ex)
return Response(content=f"Internal Server Error: {ex}", status_code=500)

Check warning

Code scanning / CodeQL

Information exposure through an exception Medium

Stack trace information
flows to this location and may be exposed to an external user.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants