Add MongoDB health check to REST routes #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsschult
approved these changes
Jan 30, 2020
|
@dsschult says this won't work against our current version of MongoDB, so we'll hold off on merging this PR for awhile. |
|
It's a mongo 3.6 feature, and the current server is 3.0. Need to wait for @barnetspa to upgrade the server. |
dsschult
requested changes
Nov 11, 2021
lta/rest_server.py
Outdated
| # configure access to MongoDB for health checks | ||
| mongodb_health_url = f"mongodb://{mongo_host}:{mongo_port}/admin" | ||
| if mongo_user and mongo_pass: | ||
| mongodb_health_url = f"mongodb://{mongo_user}:{mongo_pass}@{mongo_host}:{mongo_port}/admin" |
There was a problem hiding this comment.
The one issue I can foresee already is which db the user/pass combo is registered in. Right now, the user only exists in the specific $LTA_MONGODB_DATABASE_NAME, not in admin.
One solution is to only use the admin db, and when connecting do things like this:
logging.info(f'DB: {config["DB_URL"]}')
db_url, db_name = config['DB_URL'].rsplit('/', 1)
db = motor.motor_asyncio.AsyncIOMotorClient(db_url)
logging.info(f'DB name: {db_name}')
kwargs['db'] = db[db_name]
|
DevOps Weekly had a link to some MongoDB monitoring. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.